Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: contrib/raid
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are quite a few error messages being logged with a log level of info. That should be fixed to help debugging.

      1. MAPREDUCE-2250.2.patch
        14 kB
        Ramkumar Vadali
      2. MAPREDUCE-2250.1.patch
        13 kB
        Ramkumar Vadali
      3. MAPREDUCE-2250.patch
        13 kB
        Ramkumar Vadali

        Activity

        Ramkumar Vadali created issue -
        Hide
        Ramkumar Vadali added a comment -

        Fixes logging

        Show
        Ramkumar Vadali added a comment - Fixes logging
        Ramkumar Vadali made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-2250.patch [ 12467910 ]
        Ramkumar Vadali made changes -
        Summary Fix log levels for error messages Fix logging in raid code.
        Hide
        Ramkumar Vadali added a comment -
        Show
        Ramkumar Vadali added a comment - Review at https://reviews.apache.org/r/266/
        Ramkumar Vadali made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Scott Chen added a comment -

        +1 Looks good

        Show
        Scott Chen added a comment - +1 Looks good
        Ramkumar Vadali made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Ramkumar Vadali added a comment -

        Update after svn up

        Show
        Ramkumar Vadali added a comment - Update after svn up
        Ramkumar Vadali made changes -
        Attachment MAPREDUCE-2250.1.patch [ 12468208 ]
        Ramkumar Vadali made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hadoop Flags [Reviewed]
        Hide
        Ramkumar Vadali added a comment -

        Pulling in a test fix from another jira.

        Show
        Ramkumar Vadali added a comment - Pulling in a test fix from another jira.
        Ramkumar Vadali made changes -
        Attachment MAPREDUCE-2250.2.patch [ 12469206 ]
        Hide
        Ramkumar Vadali added a comment -

        TEST RESULTS:

             [exec]
             [exec] +1 overall.
             [exec]
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]
             [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
             [exec]
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
             [exec]
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec]
             [exec]     +1 system test framework.  The patch passed system test framework compile.
             [exec]
             [exec]
             [exec]
             [exec]
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]     Finished build.
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]
             [exec]
        
        test-junit:
            [junit] WARNING: multiple versions of ant detected in path for junit 
            [junit]          jar:file:/home/rvadali/local/external/ant/lib/ant.jar!/org/apache/tools/ant/Project.class
            [junit]      and jar:file:/home/rvadali/.ivy2/cache/ant/ant/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
            [junit] Running org.apache.hadoop.hdfs.TestRaidDfs
            [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 498.696 sec
            [junit] Running org.apache.hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRaid
            [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 153.311 sec
            [junit] Running org.apache.hadoop.raid.TestBlockFixer
            [junit] Tests run: 14, Failures: 0, Errors: 0, Time elapsed: 969.737 sec
            [junit] Running org.apache.hadoop.raid.TestDirectoryTraversal
            [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 12.785 sec
            [junit] Running org.apache.hadoop.raid.TestErasureCodes
            [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 17.575 sec
            [junit] Running org.apache.hadoop.raid.TestGaloisField
            [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.295 sec
            [junit] Running org.apache.hadoop.raid.TestHarIndexParser
            [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.038 sec
            [junit] Running org.apache.hadoop.raid.TestRaidFilter
            [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 14.459 sec
            [junit] Running org.apache.hadoop.raid.TestRaidHar
            [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 65.327 sec
            [junit] Running org.apache.hadoop.raid.TestRaidNode
            [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 512.67 sec
            [junit] Running org.apache.hadoop.raid.TestRaidPurge
            [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 254.251 sec
            [junit] Running org.apache.hadoop.raid.TestRaidShell
            [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 41.865 sec
            [junit] Running org.apache.hadoop.raid.TestRaidShellFsck
            [junit] Tests run: 11, Failures: 0, Errors: 0, Time elapsed: 257.72 sec
            [junit] Running org.apache.hadoop.raid.TestReedSolomonDecoder
            [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 12.654 sec
            [junit] Running org.apache.hadoop.raid.TestReedSolomonEncoder
            [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 3.779 sec
        
        test:
        
        BUILD SUCCESSFUL
        
        Show
        Ramkumar Vadali added a comment - TEST RESULTS: [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] test-junit: [junit] WARNING: multiple versions of ant detected in path for junit [junit] jar:file:/home/rvadali/local/external/ant/lib/ant.jar!/org/apache/tools/ant/Project.class [junit] and jar:file:/home/rvadali/.ivy2/cache/ant/ant/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class [junit] Running org.apache.hadoop.hdfs.TestRaidDfs [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 498.696 sec [junit] Running org.apache.hadoop.hdfs.server.namenode.TestBlockPlacementPolicyRaid [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 153.311 sec [junit] Running org.apache.hadoop.raid.TestBlockFixer [junit] Tests run: 14, Failures: 0, Errors: 0, Time elapsed: 969.737 sec [junit] Running org.apache.hadoop.raid.TestDirectoryTraversal [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 12.785 sec [junit] Running org.apache.hadoop.raid.TestErasureCodes [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 17.575 sec [junit] Running org.apache.hadoop.raid.TestGaloisField [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.295 sec [junit] Running org.apache.hadoop.raid.TestHarIndexParser [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.038 sec [junit] Running org.apache.hadoop.raid.TestRaidFilter [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 14.459 sec [junit] Running org.apache.hadoop.raid.TestRaidHar [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 65.327 sec [junit] Running org.apache.hadoop.raid.TestRaidNode [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 512.67 sec [junit] Running org.apache.hadoop.raid.TestRaidPurge [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 254.251 sec [junit] Running org.apache.hadoop.raid.TestRaidShell [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 41.865 sec [junit] Running org.apache.hadoop.raid.TestRaidShellFsck [junit] Tests run: 11, Failures: 0, Errors: 0, Time elapsed: 257.72 sec [junit] Running org.apache.hadoop.raid.TestReedSolomonDecoder [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 12.654 sec [junit] Running org.apache.hadoop.raid.TestReedSolomonEncoder [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 3.779 sec test: BUILD SUCCESSFUL
        Hide
        Scott Chen added a comment -

        I just committed this. Thanks Ram

        Show
        Scott Chen added a comment - I just committed this. Thanks Ram
        Scott Chen made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.23.0 [ 12315570 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #582 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/582/)
        MAPREDUCE-2250. Fix logging in raid code. (Ramkumar Vadali via schen)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #582 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/582/ ) MAPREDUCE-2250 . Fix logging in raid code. (Ramkumar Vadali via schen)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ramkumar Vadali
            Reporter:
            Ramkumar Vadali
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development