[MAPREDUCE-2243] Close all the file streams propely in a finally block to avoid their leakage.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.22.0, 0.23.0
• Fix Version/s: 0.23.0
• Component/s: jobtracker, tasktracker

Environment

NA

• Hadoop Flags: Reviewed
• Assignee: Devaraj Kavali
• Reporter: Bhallamudi Venkata Siva Kamesh
• Created: 05/Jan/11 11:29
• Updated: 15/Nov/11 00:48
• Resolved: 01/Aug/11 14:12

Description

In the following classes streams should be closed in finally block to avoid their leakage in the exceptional cases.

CompletedJobStatusStore.java
------------------------------------------
dataOut.writeInt(events.length);
for (TaskCompletionEvent event : events)

{ event.write(dataOut); }

dataOut.close() ;

EventWriter.java
----------------------
encoder.flush();
out.close();

MapTask.java
-------------------
splitMetaInfo.write(out);
out.close();

TaskLog
------------
1) str = fis.readLine();
fis.close();

2) dos.writeBytes(Long.toString(new File(logLocation, LogName.SYSLOG
.toString()).length() - prevLogLength) + "\n");
dos.close();

TotalOrderPartitioner.java
-----------------------------------
while (reader.next(key, value))

{ parts.add(key); key = ReflectionUtils.newInstance(keyClass, conf); }

reader.close();