Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2188

The new API MultithreadedMapper doesn't call the initialize method of the RecordReader

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The wrapping RecordReader in the Multithreaded Mapper is never initialized. With HADOOP-6685, this becomes a problem because the ReflectionUtils.copy requires a non-null configuration.

      1. mr2188.patch
        2 kB
        Owen O'Malley

        Activity

        Hide
        Owen O'Malley added a comment -

        This patch adds the missing call.

        Show
        Owen O'Malley added a comment - This patch adds the missing call.
        Hide
        Priyo Mustafi added a comment -

        Tested the patch several times. Looks good.

        Show
        Priyo Mustafi added a comment - Tested the patch several times. Looks good.
        Hide
        Konstantin Shvachko added a comment -

        test-patch results

             [exec] -1 overall.  
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no new tests are needed for this patch.
             [exec]                         Also please list what manual steps were performed to verify this patch.
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec]     +1 system test framework. The patch passed system test framework compile.
             [exec] ======================================================================
        
        Show
        Konstantin Shvachko added a comment - test-patch results [exec] -1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] +1 system test framework. The patch passed system test framework compile. [exec] ======================================================================
        Hide
        Konstantin Shvachko added a comment -

        I just committed this. Thank you Owen and Priyo for testing.

        Show
        Konstantin Shvachko added a comment - I just committed this. Thank you Owen and Priyo for testing.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #601 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/601/)
        MAPREDUCE-2188. The new API MultithreadedMapper doesn't initialize RecordReader. Contributed by Owen O'Malley.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #601 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/601/ ) MAPREDUCE-2188 . The new API MultithreadedMapper doesn't initialize RecordReader. Contributed by Owen O'Malley.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development