Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2147

JobInProgress has some redundant lines in its ctor

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.22.0
    • Component/s: jobtracker
    • Labels:
      None
    • Environment:

      Not environment related.

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Remove some redundant lines from JobInProgress's constructor which was re-initializing things unnecessarily.
    • Tags:
      redundant code

      Description

      In the ctor of JobInProgress class that's used by the JT, lines that create the various lists of TIPs are repeated for no purpose. Might've been due to an overlook I think.

      Attaching a patch that removes these unnecessary repeats of re-init.

        Activity

        Hide
        Harsh J added a comment -

        Patch that removes unnecessary reinits of the various TIP holding data structures.

        Show
        Harsh J added a comment - Patch that removes unnecessary reinits of the various TIP holding data structures.
        Hide
        Ravi Gummadi added a comment -

        Patch looks good.
        +1

        Show
        Ravi Gummadi added a comment - Patch looks good. +1
        Hide
        Doug Cutting added a comment -

        +1

        Show
        Doug Cutting added a comment - +1
        Hide
        Doug Cutting added a comment -

        No new tests are required, as this just removes some redundant code.

        This is not a regression or serious bug that should be merged into the 0.21 branch, so I changed it to 0.22.

        I committed this. Thanks, Harsh!

        -1 overall.  
        
            +1 @author.  The patch does not contain any @author tags.
        
            -1 tests included.  The patch doesn't appear to include any new or modified tests.
                                Please justify why no new tests are needed for this patch.
                                Also please list what manual steps were performed to verify this patch.
        
            +1 javadoc.  The javadoc tool did not generate any warning messages.
        
            +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
        
            +1 findbugs.  The patch does not introduce any new Findbugs warnings.
        
            +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        
            +1 system tests framework.  The patch passed system tests framework compile.
        
        Show
        Doug Cutting added a comment - No new tests are required, as this just removes some redundant code. This is not a regression or serious bug that should be merged into the 0.21 branch, so I changed it to 0.22. I committed this. Thanks, Harsh! -1 overall. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 system tests framework. The patch passed system tests framework compile.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development