Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2094

LineRecordReader should not seek into non-splittable, compressed streams.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: task
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When implementing a custom derivative of FileInputFormat we ran into the effect that a large Gzipped input file would be processed several times.

      A near 1GiB file would be processed around 36 times in its entirety. Thus producing garbage results and taking up a lot more CPU time than needed.

      It took a while to figure out and what we found is that the default implementation of the isSplittable method in org.apache.hadoop.mapreduce.lib.input.FileInputFormat is simply "return true;".

      This is a very unsafe default and is in contradiction with the JavaDoc of the method which states: "Is the given filename splitable? Usually, true, but if the file is stream compressed, it will not be. " . The actual implementation effectively does "Is the given filename splitable? Always true, even if the file is stream compressed using an unsplittable compression codec. "

      For our situation (where we always have Gzipped input) we took the easy way out and simply implemented an isSplittable in our class that does "return false; "

      Now there are essentially 3 ways I can think of for fixing this (in order of what I would find preferable):

      1. Implement something that looks at the used compression of the file (i.e. do migrate the implementation from TextInputFormat to FileInputFormat). This would make the method do what the JavaDoc describes.
      2. "Force" developers to think about it and make this method abstract.
      3. Use a "safe" default (i.e. return false)

        Attachments

        1. MAPREDUCE-2094-FileInputFormat-docs-v2.patch
          4 kB
          Gian Merlino
        2. MAPREDUCE-2094-2015-05-05-2328.patch
          11 kB
          Niels Basjes
        3. MAPREDUCE-2094-20140727-svn-fixed-spaces.patch
          11 kB
          Niels Basjes
        4. MAPREDUCE-2094-20140727-svn.patch
          10 kB
          Niels Basjes
        5. MAPREDUCE-2094-20140727.patch
          11 kB
          Niels Basjes
        6. MAPREDUCE-2094-2011-05-19.patch
          6 kB
          Niels Basjes
        7. M2094-1.patch
          11 kB
          Chris Douglas
        8. M2094.patch
          10 kB
          Chris Douglas

          Issue Links

            Activity

              People

              • Assignee:
                nielsbasjes Niels Basjes
                Reporter:
                nielsbasjes Niels Basjes
              • Votes:
                1 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: