Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2077

Name clash in the deprecated o.a.h.util.MemoryCalculatorPlugin

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Name clash compile error in the deprecated org.apache.hadoop.util.MemoryCalculatorPlugin due to JLS3 8.4.8.3 (cf. http://bugs.sun.com/view_bug.do?bug_id=6182950)

      The bug doesn't manifest in jdk 1.6 up to 20, but shows up in NetBeans 6.9+ due to its bundled (conforming) compiler. Fix is trivial: just remove the offending method in the deprecated subclass as its equivalent erasure is inherited from the parent class anyway.

        Activity

        Hide
        Tom White added a comment -

        +1 this looks good to me. Have you run tests/test-patch?

        Show
        Tom White added a comment - +1 this looks good to me. Have you run tests/test-patch?
        Hide
        Luke Lu added a comment -

        Have you run tests/test-patch?

        It compiles and I was hoping Hudson would do the test/test-patch. OTOH, this class (in fact, all the classes in this package inside the mr project) is not referenced anywhere in the project (though probably still in someone's config files), so it should have no impact to the result of test/test-patch.

        Show
        Luke Lu added a comment - Have you run tests/test-patch? It compiles and I was hoping Hudson would do the test/test-patch. OTOH, this class (in fact, all the classes in this package inside the mr project) is not referenced anywhere in the project (though probably still in someone's config files), so it should have no impact to the result of test/test-patch.
        Hide
        Po Cheung added a comment -

        Results of running test-patch are below. This patch does not need new/modified tests.

             [exec] -1 overall.
             [exec]
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no new tests are needed for this patch.
             [exec]                         Also please list what manual steps were performed to verify this patch.
             [exec]
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
             [exec]
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec]
             [exec]     +1 system test framework.  The patch passed system test framework compile.
        

        test-patch.properties:

        OK_RELEASEAUDIT_WARNINGS=2
        OK_FINDBUGS_WARNINGS=13
        OK_JAVADOC_WARNINGS=0
        

        "ant run-commit-tests" was successful

        Show
        Po Cheung added a comment - Results of running test-patch are below. This patch does not need new/modified tests. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. test-patch.properties: OK_RELEASEAUDIT_WARNINGS=2 OK_FINDBUGS_WARNINGS=13 OK_JAVADOC_WARNINGS=0 "ant run-commit-tests" was successful
        Hide
        Konstantin Shvachko added a comment -

        I just committed this. Thank you Luke Lu. Thanks Po for testing this.

        Show
        Konstantin Shvachko added a comment - I just committed this. Thank you Luke Lu. Thanks Po for testing this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #600 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/600/)
        MAPREDUCE-2077. Resolve name clash in the deprecated o.a.h.util.MemoryCalculatorPlugin Contributed by Luke Lu.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #600 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/600/ ) MAPREDUCE-2077 . Resolve name clash in the deprecated o.a.h.util.MemoryCalculatorPlugin Contributed by Luke Lu.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

          People

          • Assignee:
            Luke Lu
            Reporter:
            Luke Lu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development