Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2073

TestTrackerDistributedCacheManager should be up-front about requirements on build environment

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0, 1.1.0
    • Component/s: distributed-cache, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestTrackerDistributedCacheManager will fail on a system where the build directory is in any path where an ancestor doesn't have a+x permissions. On one of our hudson boxes, for example, hudson's workspace had 700 permissions and caused this test to fail reliably, but not in an obvious manner. It would be helpful if the test failed with a more obvious error message during setUp() when the build environment is misconfigured.

      1. mapreduce-2073-0.20.txt
        3 kB
        Todd Lipcon
      2. mapreduce-2073.txt
        3 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          Patch for secure 0.20, not for commit

          Show
          Todd Lipcon added a comment - Patch for secure 0.20, not for commit
          Hide
          Todd Lipcon added a comment -

          Patch for trunk.

          Tested by chmod 700 $HOME, then running tests. It used to be that it would fail in a non-obvious manner, now I get a nice message telling me my permissions are wrong. Then I did chmod a+x $HOME and the tests pass.

          Show
          Todd Lipcon added a comment - Patch for trunk. Tested by chmod 700 $HOME, then running tests. It used to be that it would fail in a non-obvious manner, now I get a nice message telling me my permissions are wrong. Then I did chmod a+x $HOME and the tests pass.
          Hide
          Tom White added a comment -

          +1 This looks good to me. Can you run test-patch on it please?

          Show
          Tom White added a comment - +1 This looks good to me. Can you run test-patch on it please?
          Hide
          Todd Lipcon added a comment -

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] -1 findbugs. The patch appears to introduce 13 new Findbugs warnings.
          [exec]
          [exec] -1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 1 warnings).
          [exec]
          [exec] +1 system test framework. The patch passed system test framework compile.

          Same as I saw in MAPREDUCE-2034, the test-patch script has some issue. The "new" findbugs and release audit issues are in files unrelated to this patch.

          Show
          Todd Lipcon added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 13 new Findbugs warnings. [exec] [exec] -1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 1 warnings). [exec] [exec] +1 system test framework. The patch passed system test framework compile. Same as I saw in MAPREDUCE-2034 , the test-patch script has some issue. The "new" findbugs and release audit issues are in files unrelated to this patch.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Todd!

          Show
          Tom White added a comment - I've just committed this. Thanks Todd!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #535 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/535/)
          MAPREDUCE-2073. TestTrackerDistributedCacheManager should be up-front about requirements on build environment. Contributed by Todd Lipcon.

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #535 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/535/ ) MAPREDUCE-2073 . TestTrackerDistributedCacheManager should be up-front about requirements on build environment. Contributed by Todd Lipcon.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )
          Hide
          Eli Collins added a comment -

          I've verified Todd's patch fixes MAPREDUCE-1549 on 20x and committed to branch. Thanks Todd!

          Show
          Eli Collins added a comment - I've verified Todd's patch fixes MAPREDUCE-1549 on 20x and committed to branch. Thanks Todd!
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development