Details
-
Type:
Test
-
Status: Closed
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: 0.22.0
-
Component/s: distributed-cache, test
-
Labels:None
-
Hadoop Flags:Reviewed
Description
TestTrackerDistributedCacheManager will fail on a system where the build directory is in any path where an ancestor doesn't have a+x permissions. On one of our hudson boxes, for example, hudson's workspace had 700 permissions and caused this test to fail reliably, but not in an obvious manner. It would be helpful if the test failed with a more obvious error message during setUp() when the build environment is misconfigured.
Issue Links
- relates to
-
MAPREDUCE-1549
TestTrackerDistributedCacheManager failed on some machines
-
- Resolved
-
Activity
I've verified Todd's patch fixes MAPREDUCE-1549 on 20x and committed to branch. Thanks Todd!
Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)
Integrated in Hadoop-Mapreduce-trunk-Commit #535 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/535/)
MAPREDUCE-2073. TestTrackerDistributedCacheManager should be up-front about requirements on build environment. Contributed by Todd Lipcon.
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 13 new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 1 warnings).
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
Same as I saw in MAPREDUCE-2034, the test-patch script has some issue. The "new" findbugs and release audit issues are in files unrelated to this patch.
+1 This looks good to me. Can you run test-patch on it please?
Patch for trunk.
Tested by chmod 700 $HOME, then running tests. It used to be that it would fail in a non-obvious manner, now I get a nice message telling me my permissions are wrong. Then I did chmod a+x $HOME and the tests pass.
Patch for secure 0.20, not for commit
Closed upon release of Hadoop-1.1.0.