Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2031

TestTaskLauncher and TestTaskTrackerLocalization fail with NPE in trunk.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: tasktracker, test
    • Labels:
      None

      Description

      TestTaskLauncher and TestTaskTrackerLocalization fail in trunk after the commit of MAPREDUCE-1881 with NPE:

      java.lang.NullPointerException
              at org.apache.hadoop.mapred.TaskTracker$TaskInProgress.kill(TaskTracker.java:2978)
              at org.apache.hadoop.mapred.TaskTracker$TaskInProgress.jobHasFinished(TaskTracker.java:2941)
              at org.apache.hadoop.mapred.TaskTracker.purgeJob(TaskTracker.java:1919)
              at org.apache.hadoop.mapred.TestTaskTrackerLocalization.verifyUserLogsRemoval(TestTaskTrackerLocalization.java:816)
              at org.apache.hadoop.mapred.TestTaskTrackerLocalization.testJobFilesRemoval(TestTaskTrackerLocalization.java:897)
      
      java.lang.NullPointerException
              at org.apache.hadoop.mapred.TaskTracker$TaskInProgress.kill(TaskTracker.java:2978)
              at org.apache.hadoop.mapred.TaskTracker$TaskInProgress.jobHasFinished(TaskTracker.java:2941)
              at org.apache.hadoop.mapred.TaskTracker.purgeTask(TaskTracker.java:1981)
              at org.apache.hadoop.mapred.TaskTracker.processKillTaskAction(TaskTracker.java:420)
              at org.apache.hadoop.mapred.TestTaskLauncher.testExternalKillForLaunchTask(TestTaskLauncher.java:95)
      

      NPE happens because taskTracker.myInstrumentation is not initialized.

      1. 2031.patch
        2 kB
        Ravi Gummadi

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        11d 18h 49m 1 Amareshwari Sriramadasu 06/Sep/10 04:39
        Resolved Resolved Closed Closed
        462d 2h 39m 1 Konstantin Shvachko 12/Dec/11 06:18
        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
        Amareshwari Sriramadasu made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        I just committed this. Thanks Ravi !

        Show
        Amareshwari Sriramadasu added a comment - I just committed this. Thanks Ravi !
        Hide
        Ravi Gummadi added a comment -

        Unit tests passed on my local machine.

        ant test-patch gave:

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 6 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system tests framework. The patch passed system tests framework compile.

        Show
        Ravi Gummadi added a comment - Unit tests passed on my local machine. ant test-patch gave: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile.
        Hide
        Amareshwari Sriramadasu added a comment -

        Patch looks fine. Please upload ant test and test-patch results.

        Show
        Amareshwari Sriramadasu added a comment - Patch looks fine. Please upload ant test and test-patch results.
        Ravi Gummadi made changes -
        Attachment 2031.patch [ 12453665 ]
        Hide
        Ravi Gummadi added a comment -

        Attaching patch by fixing the 2 test cases to initialize TaskTrackerInstrumentation.

        Show
        Ravi Gummadi added a comment - Attaching patch by fixing the 2 test cases to initialize TaskTrackerInstrumentation.
        Ravi Gummadi made changes -
        Field Original Value New Value
        Assignee Ravi Gummadi [ ravidotg ]
        Amareshwari Sriramadasu created issue -

          People

          • Assignee:
            Ravi Gummadi
            Reporter:
            Amareshwari Sriramadasu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development