Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1999

ClientProtocol incorrectly uses hdfs DelegationTokenSelector

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      ClientProtocol in MR incorrectly uses the DelegationTokenSelector in hdfs due to a wrong import. It should use the DelegationTokenSelector in mapreduce.

      1. MR-1999.1.patch
        0.7 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Jitendra Nath Pandey added a comment -

        Patch uploaded. Only one line fix.

        Show
        Jitendra Nath Pandey added a comment - Patch uploaded. Only one line fix.
        Hide
        Jitendra Nath Pandey added a comment -

        ant test was run manually. All tests pass.

        test-patch results:

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Jitendra Nath Pandey added a comment - ant test was run manually. All tests pass. test-patch results: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Jitendra Nath Pandey added a comment -

        The patch was tested manually on the trunk.

        Show
        Jitendra Nath Pandey added a comment - The patch was tested manually on the trunk.
        Hide
        Devaraj Das added a comment -

        I just committed this. Thanks, Jitendra!

        Show
        Devaraj Das added a comment - I just committed this. Thanks, Jitendra!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
        Hide
        Nigel Daley added a comment -

        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.

        Please provide this info in the future. Stating that is was manually tested on trunk is insufficient.

        Show
        Nigel Daley added a comment - [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. Please provide this info in the future. Stating that is was manually tested on trunk is insufficient.

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development