Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1980

TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None

      Description

      TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent

      /** Get the event type */
      public EventType getEventType()

      { return EventType.MAP_ATTEMPT_KILLED; }
      1. mapreduce-1980-v1.0.patch
        6 kB
        Amar Kamat
      2. mapreduce-1980-v1.1.patch
        10 kB
        Amar Kamat

        Issue Links

          Activity

          Hide
          Amar Kamat added a comment -

          Attaching a patch the fixes the bug. test-patch and ant-tests passed on my box.

          Show
          Amar Kamat added a comment - Attaching a patch the fixes the bug. test-patch and ant-tests passed on my box.
          Hide
          Hong Tang added a comment -

          Patch looks good. +1.

          Show
          Hong Tang added a comment - Patch looks good. +1.
          Hide
          Amareshwari Sriramadasu added a comment -

          The same problem is present in TaskAttemptFinishedEvent also. setup and cleanup tasks are always logged as MAP_ATTEMPT_FINISHED. Can you fix that also?

          Show
          Amareshwari Sriramadasu added a comment - The same problem is present in TaskAttemptFinishedEvent also. setup and cleanup tasks are always logged as MAP_ATTEMPT_FINISHED. Can you fix that also?
          Hide
          Amar Kamat added a comment -

          Attaching a patch that incorporates Amareshwari's comments. Modified the testcase too.

          Show
          Amar Kamat added a comment - Attaching a patch that incorporates Amareshwari's comments. Modified the testcase too.
          Hide
          Amareshwari Sriramadasu added a comment -

          Patch looks good.
          Amar, Can you post the test results? Will check-in this into trunk and branch 0.21.

          Show
          Amareshwari Sriramadasu added a comment - Patch looks good. Amar, Can you post the test results? Will check-in this into trunk and branch 0.21.
          Hide
          Amar Kamat added a comment -

          test-patch passed on my box. Few contrib tests failed but doesn't seem related to my patch. Looking into it.

          Show
          Amar Kamat added a comment - test-patch passed on my box. Few contrib tests failed but doesn't seem related to my patch. Looking into it.
          Hide
          Amareshwari Sriramadasu added a comment -

          Few contrib tests failed but doesn't seem related to my patch. Looking into it

          I just checked the failing tests. This is because of MAPREDUCE-1920. completed job store is disabled for mapred unit tests by adding it to src/test. but contrib tests would not pickup mapred-site.xml from src/test. So, the tests are failing.

          Show
          Amareshwari Sriramadasu added a comment - Few contrib tests failed but doesn't seem related to my patch. Looking into it I just checked the failing tests. This is because of MAPREDUCE-1920 . completed job store is disabled for mapred unit tests by adding it to src/test. but contrib tests would not pickup mapred-site.xml from src/test. So, the tests are failing.
          Hide
          Amareshwari Sriramadasu added a comment -

          All the tests pass after MAPREDUCE-2012
          I just committed this to trunk and branch 0.21

          Show
          Amareshwari Sriramadasu added a comment - All the tests pass after MAPREDUCE-2012 I just committed this to trunk and branch 0.21
          Hide
          Amareshwari Sriramadasu added a comment -

          Thanks Amar!

          Show
          Amareshwari Sriramadasu added a comment - Thanks Amar!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

            People

            • Assignee:
              Amar Kamat
              Reporter:
              Amar Kamat
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development