Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1894

DistributedRaidFileSystem.readFully() does not return

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: contrib/raid
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      DistributedRaidFileSystem.readFully() has a while(true) loop with no return. The read functions do not have this problem.

      1. MAPREDUCE-1894.patch
        2 kB
        Ramkumar Vadali

        Activity

        Ramkumar Vadali created issue -
        Ramkumar Vadali made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-1894.patch [ 12448454 ]
        Hide
        Ramkumar Vadali added a comment -

        Fix along with unit-tests.

        Show
        Ramkumar Vadali added a comment - Fix along with unit-tests.
        Ramkumar Vadali made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.22.0 [ 12314184 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12448454/MAPREDUCE-1894.patch
        against trunk revision 959221.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/276/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/276/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/276/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/276/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448454/MAPREDUCE-1894.patch against trunk revision 959221. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/276/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/276/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/276/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/276/console This message is automatically generated.
        Hide
        Ramkumar Vadali added a comment -

        The contrib test error seems to be hudson-related and not an actual test failure.

        Show
        Ramkumar Vadali added a comment - The contrib test error seems to be hudson-related and not an actual test failure.
        Hide
        Rodrigo Schmidt added a comment -

        +1
        Patch looks good.

        Show
        Rodrigo Schmidt added a comment - +1 Patch looks good.
        dhruba borthakur made changes -
        Assignee Ramkumar Vadali [ rvadali ]
        Hide
        dhruba borthakur added a comment -

        I just committed this. Thanks Ram!

        Show
        dhruba borthakur added a comment - I just committed this. Thanks Ram!
        dhruba borthakur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        5d 22h 41m 1 Ramkumar Vadali 30/Jun/10 23:18
        Patch Available Patch Available Resolved Resolved
        5d 8h 3m 1 dhruba borthakur 06/Jul/10 07:22
        Resolved Resolved Closed Closed
        523d 23h 57m 1 Konstantin Shvachko 12/Dec/11 06:20

          People

          • Assignee:
            Ramkumar Vadali
            Reporter:
            Ramkumar Vadali
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development