Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1819

RaidNode should be smarter in submitting Raid jobs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.1
    • Fix Version/s: 0.22.0
    • Component/s: contrib/raid
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The RaidNode currently computes parity files as follows:
      1. Using RaidNode.selectFiles() to figure out what files to raid for a policy
      2. Using #1 repeatedly for each configured policy to accumulate a list of files.
      3. Submitting a mapreduce job with the list of files from #2 using DistRaid.doDistRaid()

      This task addresses the fact that #2 and #3 happen sequentially. The proposal is to submit a separate mapreduce job for the list of files for each policy and use another thread to track the progress of the submitted jobs. This will help reduce the time taken for files to be raided.

      1. MAPREDUCE-1819.5.patch
        155 kB
        Ramkumar Vadali
      2. MAPREDUCE-1819.4.patch
        155 kB
        Ramkumar Vadali
      3. MAPREDUCE-1819.patch.3
        155 kB
        Ramkumar Vadali
      4. MAPREDUCE-1819.patch.2
        153 kB
        Ramkumar Vadali
      5. MAPREDUCE-1819.patch
        154 kB
        Ramkumar Vadali

        Activity

        Hide
        Ramkumar Vadali added a comment -

        This becomes important when the some of the parity files have been compacted into HAR archives. RaidNode.selectFiles becomes very slow in such cases because it repeatedly has to get data blocks for the HAR archive just to read metadata.

        Show
        Ramkumar Vadali added a comment - This becomes important when the some of the parity files have been compacted into HAR archives. RaidNode.selectFiles becomes very slow in such cases because it repeatedly has to get data blocks for the HAR archive just to read metadata.
        Hide
        Ramkumar Vadali added a comment -

        The intention of the task is to achieve concurrency between RaidNode.selectFiles() and submission of Raid MR jobs. The original solution proposed is narrow in scope - it only works when there are quite a few policies specified so that a MR job for a policy can run while selectFiles() is running for other policies.

        But depending on the policy is not a good design. Instead, the following proposal is better:

        1. For each policy, start a directory traversal as specified by the policy. When a certain number of files have been selected for Raiding, save the traversal state and submit a MR job.

        • move on to the next policy
          2. After looping through all the policies, submit a job for a policy only if there are not enough jobs running for it already.

        The limit on the number of files and number of running jobs will need to be configurable. With this design, if there is a single policy covering a large number of files, we can still have sufficient concurrency between selectFiles() and running jobs.

        I will submit a patch with this design.

        Show
        Ramkumar Vadali added a comment - The intention of the task is to achieve concurrency between RaidNode.selectFiles() and submission of Raid MR jobs. The original solution proposed is narrow in scope - it only works when there are quite a few policies specified so that a MR job for a policy can run while selectFiles() is running for other policies. But depending on the policy is not a good design. Instead, the following proposal is better: 1. For each policy, start a directory traversal as specified by the policy. When a certain number of files have been selected for Raiding, save the traversal state and submit a MR job. move on to the next policy 2. After looping through all the policies, submit a job for a policy only if there are not enough jobs running for it already. The limit on the number of files and number of running jobs will need to be configurable. With this design, if there is a single policy covering a large number of files, we can still have sufficient concurrency between selectFiles() and running jobs. I will submit a patch with this design.
        Hide
        Ramkumar Vadali added a comment -

        This patch implements the design of suspending directory traversal when a certain number of files have been selected for RAIDing. It introduces the class DirectoryTraversal which uses a stack to remember the traversal state. The number of running jobs is tracked using the class JobMonitor.

        Show
        Ramkumar Vadali added a comment - This patch implements the design of suspending directory traversal when a certain number of files have been selected for RAIDing. It introduces the class DirectoryTraversal which uses a stack to remember the traversal state. The number of running jobs is tracked using the class JobMonitor.
        Hide
        Ramkumar Vadali added a comment -

        Removing unrelated change from DistributedRaidFileSystem.java

        Show
        Ramkumar Vadali added a comment - Removing unrelated change from DistributedRaidFileSystem.java
        Hide
        Ramkumar Vadali added a comment -

        ant test-patch results:
        This succeeded:
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 16 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system tests framework. The patch passed system tests framework compile.
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Finished build.
        [exec] ======================================================================
        [exec] ======================================================================
        [exec]
        [exec]

        ant test results:
        This succeeded except for an unrelated test failure.

        [junit] Running org.apache.hadoop.streaming.TestUlimit
        [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 66.29 sec
        [junit] Test org.apache.hadoop.streaming.TestUlimit FAILED

        Show
        Ramkumar Vadali added a comment - ant test-patch results: This succeeded: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 16 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] ant test results: This succeeded except for an unrelated test failure. [junit] Running org.apache.hadoop.streaming.TestUlimit [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 66.29 sec [junit] Test org.apache.hadoop.streaming.TestUlimit FAILED
        Hide
        Scott Chen added a comment -

        It seems to me that the intention in the following part in RaidNode.java is not very clear.

                    int runningJobsCount = jobMonitor.runningJobsCount(info.getName());
                    // Is there a scan in progress for this policy?
                    if (scanState.containsKey(info.getName())) {
                      // If there is a scan in progress for this policy, we can have
                      // upto maxJobsPerPolicy running jobs.
                      if (runningJobsCount >= maxJobsPerPolicy) {
                        continue;
                      }
                    } else {
                      // If there isn't a scan in progress for this policy, we don't
                      // want to start a fresh scan if there is even one running job.
                      if (runningJobsCount >= 1) {
                        continue;
                      }
                    }
        

        Also the logic which checks the period of policy is inside selectFiles().
        Maybe we can put it a method (something like shouldProcessPolicy()) along with the above logic.

        Show
        Scott Chen added a comment - It seems to me that the intention in the following part in RaidNode.java is not very clear. int runningJobsCount = jobMonitor.runningJobsCount(info.getName()); // Is there a scan in progress for this policy? if (scanState.containsKey(info.getName())) { // If there is a scan in progress for this policy, we can have // upto maxJobsPerPolicy running jobs. if (runningJobsCount >= maxJobsPerPolicy) { continue ; } } else { // If there isn't a scan in progress for this policy, we don't // want to start a fresh scan if there is even one running job. if (runningJobsCount >= 1) { continue ; } } Also the logic which checks the period of policy is inside selectFiles(). Maybe we can put it a method (something like shouldProcessPolicy()) along with the above logic.
        Hide
        Ramkumar Vadali added a comment -

        Addressed Scott's comments. The logic to decided if more files need to be selected for RAIDing for a policy is now factored out into another function shouldSelectFiles()

        Show
        Ramkumar Vadali added a comment - Addressed Scott's comments. The logic to decided if more files need to be selected for RAIDing for a policy is now factored out into another function shouldSelectFiles()
        Hide
        Ramkumar Vadali added a comment -

        ant test-patch:

        [exec]
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 16 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system tests framework. The patch passed system tests framework compile.
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Finished build.
        [exec] ======================================================================
        [exec] ======================================================================
        [exec]
        [exec]

        ant-test:

        All succeeded except TestUlimit which is not a related failure.

        Show
        Ramkumar Vadali added a comment - ant test-patch: [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 16 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] ant-test: All succeeded except TestUlimit which is not a related failure.
        Hide
        Scott Chen added a comment -

        +1, Looks good. Just one small thing. Can we directly return true here?

        RaidNode.java
        +        } else {
        +          return (now() > configMgr.getPeriodicity());
        +        }
        
        Show
        Scott Chen added a comment - +1, Looks good. Just one small thing. Can we directly return true here? RaidNode.java + } else { + return (now() > configMgr.getPeriodicity()); + }
        Hide
        Ramkumar Vadali added a comment -

        Return true directly in shouldSelectFiles(), merge changes with recent commits after svn up.

        Test Results:
        ===========

        ant test-patch

        1819 latest

        [exec]
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 16 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system tests framework. The patch passed system tests framework compile.
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Finished build.
        [exec] ======================================================================
        [exec] ======================================================================

        ant test:

        There were test failures, but those failures were present in a clean checkout as well. The patch does not introduce any new failures. The following are the tests that failed on a clean checkout:

        [junit] Test org.apache.hadoop.mapred.TestMapRed FAILED
        [junit] Test org.apache.hadoop.mapred.TestSequenceFileInputFormat FAILED
        [junit] Test org.apache.hadoop.io.TestSequenceFile FAILED
        [junit] Test org.apache.hadoop.mapred.TestControlledMapReduceJob FAILED (timeout)
        [junit] Test org.apache.hadoop.mapred.TestJobQueueInformation FAILED
        [junit] Test org.apache.hadoop.mapred.TestSequenceFileAsTextInputFormat FAILED
        [junit] Test org.apache.hadoop.mapred.TestSequenceFileInputFilter FAILED
        [junit] Test org.apache.hadoop.mapreduce.TestMapReduce FAILED
        [junit] Test org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileAsTextInputFormat FAILED
        [junit] Test org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileInputFilter FAILED
        [junit] Test org.apache.hadoop.record.TestRecordMR FAILED

        Show
        Ramkumar Vadali added a comment - Return true directly in shouldSelectFiles(), merge changes with recent commits after svn up. Test Results: =========== ant test-patch 1819 latest [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 16 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== ant test: There were test failures, but those failures were present in a clean checkout as well. The patch does not introduce any new failures. The following are the tests that failed on a clean checkout: [junit] Test org.apache.hadoop.mapred.TestMapRed FAILED [junit] Test org.apache.hadoop.mapred.TestSequenceFileInputFormat FAILED [junit] Test org.apache.hadoop.io.TestSequenceFile FAILED [junit] Test org.apache.hadoop.mapred.TestControlledMapReduceJob FAILED (timeout) [junit] Test org.apache.hadoop.mapred.TestJobQueueInformation FAILED [junit] Test org.apache.hadoop.mapred.TestSequenceFileAsTextInputFormat FAILED [junit] Test org.apache.hadoop.mapred.TestSequenceFileInputFilter FAILED [junit] Test org.apache.hadoop.mapreduce.TestMapReduce FAILED [junit] Test org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileAsTextInputFormat FAILED [junit] Test org.apache.hadoop.mapreduce.lib.input.TestMRSequenceFileInputFilter FAILED [junit] Test org.apache.hadoop.record.TestRecordMR FAILED
        Hide
        Scott Chen added a comment -
        ant test-core -Dtestcase=TestMapRed
        
            [junit] Running org.apache.hadoop.mapred.TestMapRed
            [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 25.966 sec
        
        checkfailure:
        
        run-test-mapred:
        
        BUILD SUCCESSFUL
        Total time: 37 seconds
        
        

        Worked on my box.

        Show
        Scott Chen added a comment - ant test-core -Dtestcase=TestMapRed [junit] Running org.apache.hadoop.mapred.TestMapRed [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 25.966 sec checkfailure: run-test-mapred: BUILD SUCCESSFUL Total time: 37 seconds Worked on my box.
        Hide
        Ramkumar Vadali added a comment -

        I re-ran ant test-patch, that succeeded. I ran ant test-patch under src/contrib/raid and that succeeded too. Since the patch touches code under src/contrib/raid only, I did not run ant test from the top level. I think that should be OK.

        [exec]
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 16 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system tests framework. The patch passed system tests framework compile.
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Finished build.
        [exec] ======================================================================
        [exec] ======================================================================
        [exec]
        [exec]

        BUILD SUCCESSFUL
        Total time: 18 minutes 17 seconds

        test-junit:
        [junit] WARNING: multiple versions of ant detected in path for junit
        [junit] jar:file:/home/rvadali/local/external/ant/lib/ant.jar!/org/apache/tools/ant/Project.class
        [junit] and jar:file:/home/rvadali/.ivy2/cache/ant/ant/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
        [junit] Running org.apache.hadoop.hdfs.TestRaidDfs
        [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 37.74 sec
        [junit] Running org.apache.hadoop.raid.TestDirectoryTraversal
        [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 8.185 sec
        [junit] Running org.apache.hadoop.raid.TestRaidHar
        [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 68.763 sec
        [junit] Running org.apache.hadoop.raid.TestRaidNode
        [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 464.922 sec
        [junit] Running org.apache.hadoop.raid.TestRaidPurge
        [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 44.036 sec

        test:

        BUILD SUCCESSFUL
        Total time: 10 minutes 38 seconds

        Show
        Ramkumar Vadali added a comment - I re-ran ant test-patch, that succeeded. I ran ant test-patch under src/contrib/raid and that succeeded too. Since the patch touches code under src/contrib/raid only, I did not run ant test from the top level. I think that should be OK. [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 16 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] BUILD SUCCESSFUL Total time: 18 minutes 17 seconds test-junit: [junit] WARNING: multiple versions of ant detected in path for junit [junit] jar: file:/home/rvadali/local/external/ant/lib/ant.jar!/org/apache/tools/ant/Project.class [junit] and jar: file:/home/rvadali/.ivy2/cache/ant/ant/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class [junit] Running org.apache.hadoop.hdfs.TestRaidDfs [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 37.74 sec [junit] Running org.apache.hadoop.raid.TestDirectoryTraversal [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 8.185 sec [junit] Running org.apache.hadoop.raid.TestRaidHar [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 68.763 sec [junit] Running org.apache.hadoop.raid.TestRaidNode [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 464.922 sec [junit] Running org.apache.hadoop.raid.TestRaidPurge [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 44.036 sec test: BUILD SUCCESSFUL Total time: 10 minutes 38 seconds
        Hide
        Scott Chen added a comment -

        +1 Looks good.
        Let's wait for a few days. Then I will commit it.

        Show
        Scott Chen added a comment - +1 Looks good. Let's wait for a few days. Then I will commit it.
        Hide
        Ramkumar Vadali added a comment -

        Modifying patch after svn up.

        Test Results:

        test-junit:
        [junit] WARNING: multiple versions of ant detected in path for junit
        [junit] jar:file:/home/rvadali/local/external/ant/lib/ant.jar!/org/apache/tools/ant/Project.class
        [junit] and jar:file:/home/rvadali/.ivy2/cache/ant/ant/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
        [junit] Running org.apache.hadoop.hdfs.TestRaidDfs
        [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 28.33 sec
        [junit] Running org.apache.hadoop.raid.TestDirectoryTraversal
        [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 8.603 sec
        [junit] Running org.apache.hadoop.raid.TestRaidHar
        [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 69.846 sec
        [junit] Running org.apache.hadoop.raid.TestRaidNode
        [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 408.472 sec
        [junit] Running org.apache.hadoop.raid.TestRaidPurge
        [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 44.013 sec

        test:

        BUILD SUCCESSFUL
        Total time: 9 minutes 34 seconds

        Show
        Ramkumar Vadali added a comment - Modifying patch after svn up. Test Results: test-junit: [junit] WARNING: multiple versions of ant detected in path for junit [junit] jar: file:/home/rvadali/local/external/ant/lib/ant.jar!/org/apache/tools/ant/Project.class [junit] and jar: file:/home/rvadali/.ivy2/cache/ant/ant/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class [junit] Running org.apache.hadoop.hdfs.TestRaidDfs [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 28.33 sec [junit] Running org.apache.hadoop.raid.TestDirectoryTraversal [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 8.603 sec [junit] Running org.apache.hadoop.raid.TestRaidHar [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 69.846 sec [junit] Running org.apache.hadoop.raid.TestRaidNode [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 408.472 sec [junit] Running org.apache.hadoop.raid.TestRaidPurge [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 44.013 sec test: BUILD SUCCESSFUL Total time: 9 minutes 34 seconds
        Hide
        Ramkumar Vadali added a comment -

        ant test-patch also succeeded

        [exec]
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 16 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system tests framework. The patch passed system tests framework compile.
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Finished build.
        [exec] ======================================================================
        [exec] ======================================================================
        [exec]
        [exec]

        Show
        Ramkumar Vadali added a comment - ant test-patch also succeeded [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 16 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec]
        Hide
        Scott Chen added a comment -

        I have committed this. Thanks, Ram.

        Show
        Scott Chen added a comment - I have committed this. Thanks, Ram.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

          People

          • Assignee:
            Ramkumar Vadali
            Reporter:
            Ramkumar Vadali
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development