Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1749

Pull configuration strings out of JobContext

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The configuration strings should not have been included in JobContext, because they distract from the intended use of the interface.

      1. mr-1749.patch
        180 kB
        Owen O'Malley

        Activity

        Hide
        Owen O'Malley added a comment -

        Just added the file.

        Show
        Owen O'Malley added a comment - Just added the file.
        Hide
        Amareshwari Sriramadasu added a comment -

        svn add for the newly added file MRJobConfig.java is not done. It seems trunk compilation is broken after the commit, can somebody add the new file?

        Show
        Amareshwari Sriramadasu added a comment - svn add for the newly added file MRJobConfig.java is not done. It seems trunk compilation is broken after the commit, can somebody add the new file?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443329/mr-1749.patch
        against trunk revision 939505.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 81 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/531/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/531/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/531/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443329/mr-1749.patch against trunk revision 939505. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 81 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/531/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/531/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/531/console This message is automatically generated.
        Hide
        Owen O'Malley added a comment -

        I just committed this.

        Show
        Owen O'Malley added a comment - I just committed this.
        Hide
        Chris Douglas added a comment -

        +1

        Job as public, evolving and these keys as private, evolving makes a lot of sense.

        Show
        Chris Douglas added a comment - +1 Job as public, evolving and these keys as private, evolving makes a lot of sense.
        Hide
        Owen O'Malley added a comment -

        Pull the strings out into MRJobConfig, which is marked private, evolving.

        Show
        Owen O'Malley added a comment - Pull the strings out into MRJobConfig, which is marked private, evolving.

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development