Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1740

NPE in getMatchingLevelForNodes when node locations are variable depth

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.20.3
    • 1.1.0, 2.0.0-alpha
    • jobtracker
    • None
    • Reviewed

    Description

      In getMatchingLevelForNodes, we assume that both nodes have the same "depth" (ie number of path components). If the user provides a topology script that assigns one node a path like /foo/bar/baz and another node a path like /foo/blah, this function will throw an NPE.

      I'm not sure if there are other places where we assume that all node locations have a constant number of paths. If so we should check the output of the topology script aggressively to be sure this is the case. Otherwise I think we simply need to add && n2 != null to the while loop

      Attachments

        1. mapreduce-1740.txt
          6 kB
          Todd Lipcon
        2. MAPREDUCE-1740.patch
          7 kB
          Ahmed Radwan
        3. MAPREDUCE-1740_trunk.patch
          6 kB
          Ahmed Radwan
        4. MAPREDUCE-1740_branch-1.0.patch
          7 kB
          Ahmed Radwan

        Issue Links

          Activity

            People

              ahmed.radwan Ahmed Radwan
              tlipcon Todd Lipcon
              Votes:
              2 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: