Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1731

Process tree clean up suspended task tests.

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • test
    • None

    Description

      1 .Verify the process tree cleanup of suspended task and task should be terminated after timeout.
      2. Verify the process tree cleanup of suspended task and resume the task before task timeout.

      Attachments

        1. MAPREDUCE-1731.patch
          12 kB
          Vinay Kumar Thota
        2. 1731-ydist-security.patch
          12 kB
          Vinay Kumar Thota
        3. 1731-ydist-security.patch
          11 kB
          Vinay Kumar Thota
        4. 1731-ydist-security.patch
          11 kB
          Vinay Kumar Thota
        5. suspendtask_1731.patch
          11 kB
          Vinay Kumar Thota
        6. suspendtask_1731.patch
          11 kB
          Vinay Kumar Thota

        Issue Links

          Activity

            Please review it and let me know your comments.

            vinaythota Vinay Kumar Thota added a comment - Please review it and let me know your comments.

            Hi Vinay. Code looks good. Some comments.

            1) After suspending task, immediately the task may not die, it will still be visible when ps command is given. So, check the Assert statements immediately after suspending.

            2) space between paramters of methods

            3) Assert.AssertEquals ExitCode - Give more detailed info like "cannot suspend task"

            iyappans Iyappan Srinivasan added a comment - Hi Vinay. Code looks good. Some comments. 1) After suspending task, immediately the task may not die, it will still be visible when ps command is given. So, check the Assert statements immediately after suspending. 2) space between paramters of methods 3) Assert.AssertEquals ExitCode - Give more detailed info like "cannot suspend task"

            Mostly looks good, but I do not find the server side code for suspending and resuming task with this patch.

            balajirg Balaji Rajagopalan added a comment - Mostly looks good, but I do not find the server side code for suspending and resuming task with this patch.

            Maintaining separate ticket for that functionality.

            vinaythota Vinay Kumar Thota added a comment - Maintaining separate ticket for that functionality.

            If that is the case please call out the dependencies.

            balajirg Balaji Rajagopalan added a comment - If that is the case please call out the dependencies.

            Addressed Iyappan comments. This patch has dependency on other patch which covers the suspend and resume process functionality.

            vinaythota Vinay Kumar Thota added a comment - Addressed Iyappan comments. This patch has dependency on other patch which covers the suspend and resume process functionality.

            please link the other JIRA as a blocker of this one

            cos Konstantin I Boudnik added a comment - please link the other JIRA as a blocker of this one

            Hi Cos,

            It's a framework related change and I have a created a bugzilla ticket for that, so I can't mention the bugzilla ticket number against this JIRA ticket as a dependency. Instead of that I have mentioned that there is dependency to this ticket.

            The patch which is dependent to this ticket.

            http://bug.corp.yahoo.com/show_bug.cgi?id=3603394

            -Vinay

            vinaythota Vinay Kumar Thota added a comment - Hi Cos, It's a framework related change and I have a created a bugzilla ticket for that, so I can't mention the bugzilla ticket number against this JIRA ticket as a dependency. Instead of that I have mentioned that there is dependency to this ticket. The patch which is dependent to this ticket. http://bug.corp.yahoo.com/show_bug.cgi?id=3603394 -Vinay

            This patch is having a dependency of MAPREDUCE-1753 patch.

            vinaythota Vinay Kumar Thota added a comment - This patch is having a dependency of MAPREDUCE-1753 patch.

            Patch for Yahoo distribution security branch.

            vinaythota Vinay Kumar Thota added a comment - Patch for Yahoo distribution security branch.

            + cluster.setUp();
            + cluster.restartClusterWithNewConfig(prop, confFile);
            + UtilsForTests.waitFor(1000);
            + cluster.setUp();

            The setUp should be called only once, if it is really required to call setUp two times, then there is something wrong with the current design which can be improved, we need to investigate further into this. Vinay can you please justify why are calling setUp two times, can we overcome this by changing the current framework implementation.

            balajirg Balaji Rajagopalan added a comment - + cluster.setUp(); + cluster.restartClusterWithNewConfig(prop, confFile); + UtilsForTests.waitFor(1000); + cluster.setUp(); The setUp should be called only once, if it is really required to call setUp two times, then there is something wrong with the current design which can be improved, we need to investigate further into this. Vinay can you please justify why are calling setUp two times, can we overcome this by changing the current framework implementation.

            It was a patch mistake. I have uploaded latest patch,please check it.

            vinaythota Vinay Kumar Thota added a comment - It was a patch mistake. I have uploaded latest patch,please check it.

            I think once MAPREDUCE-1713 is updated and committed this one will need to be fixed as well. In part of removing resetClusterWithDefaultConfig, etc. Also, MAPREDUCE-1753 has some questions which have to be answered first.

            cos Konstantin I Boudnik added a comment - I think once MAPREDUCE-1713 is updated and committed this one will need to be fixed as well. In part of removing resetClusterWithDefaultConfig , etc. Also, MAPREDUCE-1753 has some questions which have to be answered first.

            MAPREDUCE-1713 patch affects this patch because of dependency.So, uploading the new patch.

            vinaythota Vinay Kumar Thota added a comment - MAPREDUCE-1713 patch affects this patch because of dependency.So, uploading the new patch.

            +1 from me.

            balajirg Balaji Rajagopalan added a comment - +1 from me.

            Patch for trunk.

            vinaythota Vinay Kumar Thota added a comment - Patch for trunk.

            I think once all the dependencies are cleared and patch is verified we can commit it.

            cos Konstantin I Boudnik added a comment - I think once all the dependencies are cleared and patch is verified we can commit it.

            Fixed?

            aw Allen Wittenauer added a comment - Fixed?

            People

              vinaythota Vinay Kumar Thota
              vinaythota Vinay Kumar Thota
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: