Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fixed a testcase problem in TestJobACLs.

      Description

      HADOOP-6686, an incompatbile change, removed exception class name in unwrapped exceptions thrown at the RPC client. TestJobACLs depended on this for verifying exceptions, and thus is broken now.

      1. 1727.patch
        3 kB
        Ravi Gummadi
      2. 1727.v1.patch
        4 kB
        Ravi Gummadi

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          1d 3h 7m 1 Amareshwari Sriramadasu 27/Apr/10 11:30
          Patch Available Patch Available Resolved Resolved
          20h 53m 1 Vinod Kumar Vavilapalli 28/Apr/10 08:23
          Resolved Resolved Closed Closed
          118d 13h 58m 1 Tom White 24/Aug/10 22:21
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Tom White made changes -
          Fix Version/s 0.21.0 [ 12314045 ]
          Fix Version/s 0.22.0 [ 12314184 ]
          Vinod Kumar Vavilapalli made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Release Note Fixed a testcase problem in TestJobACLs.
          Resolution Fixed [ 1 ]
          Hide
          Vinod Kumar Vavilapalli added a comment -

          I just committed this. Thanks Ravi!

          Show
          Vinod Kumar Vavilapalli added a comment - I just committed this. Thanks Ravi!
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12442947/1727.v1.patch
          against trunk revision 938387.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/147/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/147/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/147/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/147/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442947/1727.v1.patch against trunk revision 938387. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/147/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/147/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/147/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/147/console This message is automatically generated.
          Amareshwari Sriramadasu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Amareshwari Sriramadasu added a comment -

          Change looks fine. Running through hudson.

          Show
          Amareshwari Sriramadasu added a comment - Change looks fine. Running through hudson.
          Ravi Gummadi made changes -
          Attachment 1727.v1.patch [ 12442947 ]
          Hide
          Ravi Gummadi added a comment -

          Attaching patch with the suggested change.

          Show
          Ravi Gummadi added a comment - Attaching patch with the suggested change.
          Hide
          Amareshwari Sriramadasu added a comment -

          How about making TestJobACLs validate the expected error message instead ?

          +1

          Shall we store the error message in a String and compare, instead of having the same String in all the checks?

          Show
          Amareshwari Sriramadasu added a comment - How about making TestJobACLs validate the expected error message instead ? +1 Shall we store the error message in a String and compare, instead of having the same String in all the checks?
          Ravi Gummadi made changes -
          Attachment 1727.patch [ 12442938 ]
          Hide
          Ravi Gummadi added a comment -

          How about making TestJobACLs validate the expected error message instead ?

          Attaching patch for trunk with the testcase fix.

          Show
          Ravi Gummadi added a comment - How about making TestJobACLs validate the expected error message instead ? Attaching patch for trunk with the testcase fix.
          Ravi Gummadi made changes -
          Assignee Ravi Gummadi [ ravidotg ]
          Vinod Kumar Vavilapalli made changes -
          Fix Version/s 0.22.0 [ 12314184 ]
          Affects Version/s 0.22.0 [ 12314184 ]
          Vinod Kumar Vavilapalli made changes -
          Field Original Value New Value
          Link This issue is related to HADOOP-6686 [ HADOOP-6686 ]
          Vinod Kumar Vavilapalli created issue -

            People

            • Assignee:
              Ravi Gummadi
              Reporter:
              Vinod Kumar Vavilapalli
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development