Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1680

Add a metrics to track the number of heartbeats processed

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Added a metric to track number of heartbeats processed by the JobTracker.

      Description

      It would be nice to add a metrics that tracks the number of heartbeats processed by JT.

        Activity

        Hide
        Arun C Murthy added a comment -

        Some feedback:

        1. We do not need both JobTrackerInstrumentation.heartbeat and JobTrackerInstrumentation.heartbeats(int), just one of the apis should suffice - say JobTrackerInstrumentation.heartbeat(long increment).
        2. You'll need to get JobTrackerMetricsInst.doUpdates to send them out by incrementing a metric, say "heartbeat"
        Show
        Arun C Murthy added a comment - Some feedback: We do not need both JobTrackerInstrumentation.heartbeat and JobTrackerInstrumentation.heartbeats(int), just one of the apis should suffice - say JobTrackerInstrumentation.heartbeat(long increment). You'll need to get JobTrackerMetricsInst.doUpdates to send them out by incrementing a metric, say "heartbeat"
        Hide
        Dick King added a comment -

        This patch is meant for 0.20 and trunk

        Show
        Dick King added a comment - This patch is meant for 0.20 and trunk
        Hide
        Dick King added a comment -

        I hereby license the attachment "mapreduce-1680--2010-04-08.patch (3 kB)" to ASF.

        [That checkbox appears to have disappeared from the JIRA file attachment tool.]

        Show
        Dick King added a comment - I hereby license the attachment "mapreduce-1680--2010-04-08.patch (3 kB)" to ASF. [That checkbox appears to have disappeared from the JIRA file attachment tool.]
        Hide
        Dick King added a comment -

        The previous patch was intended for 0.20 branches. This one is intended for Trunk.

        Show
        Dick King added a comment - The previous patch was intended for 0.20 branches. This one is intended for Trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12441632/mapreduce-1680--2010-04-08-for-trunk.patch
        against trunk revision 937922.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/137/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/137/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/137/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/137/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12441632/mapreduce-1680--2010-04-08-for-trunk.patch against trunk revision 937922. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/137/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/137/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/137/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/137/console This message is automatically generated.
        Hide
        Amareshwari Sriramadasu added a comment -

        Patch looks fine. Can you update the testcase TestJobTrackerInstrumentation.testMetrics() to test the new metric ?

        Show
        Amareshwari Sriramadasu added a comment - Patch looks fine. Can you update the testcase TestJobTrackerInstrumentation.testMetrics() to test the new metric ?
        Hide
        Dick King added a comment -

        OK, this adds a clause to one of the test cases in TestJobTrackerInstrumentation, for heartbeats.

        Show
        Dick King added a comment - OK, this adds a clause to one of the test cases in TestJobTrackerInstrumentation , for heartbeats.
        Hide
        Amareshwari Sriramadasu added a comment -

        +1 patch looks fine to me.

        Show
        Amareshwari Sriramadasu added a comment - +1 patch looks fine to me.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12443238/mapreduce-1680--2010-04-29.patch
        against trunk revision 939505.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/159/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/159/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/159/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/159/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443238/mapreduce-1680--2010-04-29.patch against trunk revision 939505. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/159/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/159/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/159/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/159/console This message is automatically generated.
        Hide
        Chris Douglas added a comment -

        +1

        I committed this. Thanks, Dick!

        Show
        Chris Douglas added a comment - +1 I committed this. Thanks, Dick!

          People

          • Assignee:
            Dick King
            Reporter:
            Hong Tang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development