Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1629

Get rid of fakeBlockLocations() on HarFileSystem, since it's not used

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      On HarFileSystem.java, I think function fakeBlockLocations() was left behind when Mahadev fixed HADOOP-6467.

      1. MAPREDUCE-1629.patch
        0.9 kB
        Mahadev konar

        Issue Links

          Activity

          Rodrigo Schmidt created issue -
          Rodrigo Schmidt made changes -
          Field Original Value New Value
          Link This issue relates to HADOOP-6467 [ HADOOP-6467 ]
          Mahadev konar made changes -
          Project Hadoop Common [ 12310240 ] Hadoop Map/Reduce [ 12310941 ]
          Key HADOOP-6650 MAPREDUCE-1629
          Affects Version/s 0.22.0 [ 12314184 ]
          Affects Version/s 0.22.0 [ 12314296 ]
          Fix Version/s 0.22.0 [ 12314184 ]
          Fix Version/s 0.22.0 [ 12314296 ]
          Hide
          Mahadev konar added a comment -

          a minor patch removing the code!

          Show
          Mahadev konar added a comment - a minor patch removing the code!
          Mahadev konar made changes -
          Attachment MAPREDUCE-1629.patch [ 12439735 ]
          Mahadev konar made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Rodrigo Schmidt added a comment -

          +1. Not much to review.

          Show
          Rodrigo Schmidt added a comment - +1. Not much to review.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12439735/MAPREDUCE-1629.patch
          against trunk revision 927488.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/60/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/60/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/60/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/60/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439735/MAPREDUCE-1629.patch against trunk revision 927488. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/60/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/60/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/60/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/60/console This message is automatically generated.
          Mahadev konar made changes -
          Assignee Rodrigo Schmidt [ rschmidt ] Mahadev konar [ mahadev ]
          Hide
          Mahadev konar added a comment -

          I just committed this.

          Show
          Mahadev konar added a comment - I just committed this.
          Mahadev konar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #293 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/293/)
          . Get rid of fakeBlockLocations() on HarFileSystem, since it's not used (mahadev)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #293 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/293/ ) . Get rid of fakeBlockLocations() on HarFileSystem, since it's not used (mahadev)
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #271 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/271/)
          . Get rid of fakeBlockLocations() on HarFileSystem, since it's not used (mahadev)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #271 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/271/ ) . Get rid of fakeBlockLocations() on HarFileSystem, since it's not used (mahadev)
          Tom White made changes -
          Fix Version/s 0.21.0 [ 12314045 ]
          Fix Version/s 0.22.0 [ 12314184 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Mahadev konar
              Reporter:
              Rodrigo Schmidt
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development