Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1627

HadoopArchives should not uses DistCp method

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: harchive
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      //line 502.
        final String randomId = DistCp.getRandomId();
      

      If HadoopArchives does not use the DistCp method, it could be packaged as a standalone tool.

      1. m1627_20100324b.patch
        2 kB
        Tsz Wo Nicholas Sze
      2. m1627_20100324.patch
        2 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        m1627_20100324.patch: generate a random id directly.

        Show
        Tsz Wo Nicholas Sze added a comment - m1627_20100324.patch: generate a random id directly.
        Hide
        Mahadev konar added a comment -

        +1 great job nicholas!!

        Show
        Mahadev konar added a comment - +1 great job nicholas!!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        m1627_20100324b.patch: uses a similar way as DistCp to generate random ids.

        Show
        Tsz Wo Nicholas Sze added a comment - m1627_20100324b.patch: uses a similar way as DistCp to generate random ids.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12439725/m1627_20100324b.patch
        against trunk revision 927187.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/57/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/57/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/57/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439725/m1627_20100324b.patch against trunk revision 927187. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/57/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/57/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/57/console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I did not add any new test since this is a trivial change.

        Show
        Tsz Wo Nicholas Sze added a comment - I did not add any new test since this is a trivial change.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #293 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/293/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #293 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/293/ )

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development