Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1593

[Rumen] Improvements to random seed generation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: tools/rumen
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      RandomSeedGenerator introduced in MAPREDUCE-1306 could be more efficient by reusing the MD5 object across calls. Wrapping the MD5 in a ThreadLocal makes the call thread safe as well. Neither of these is an issue with the current client, the mumak simulator, but the changes are small and make the code more useful in the future. Thanks to Chris Douglas for the suggestion.

        Activity

        Hide
        Hong Tang added a comment -

        +1.

        Show
        Hong Tang added a comment - +1.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12438552/MAPREDUCE-1593-20100311.patch
        against trunk revision 922047.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438552/MAPREDUCE-1593-20100311.patch against trunk revision 922047. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/522/console This message is automatically generated.
        Hide
        Tamas Sarlos added a comment -

        Resubmitting the same patch as Hudson's link to the test report is a 404

        Show
        Tamas Sarlos added a comment - Resubmitting the same patch as Hudson's link to the test report is a 404
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12438953/MAPREDUCE-1593-20100311-dup.patch
        against trunk revision 923907.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438953/MAPREDUCE-1593-20100311-dup.patch against trunk revision 923907. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/36/console This message is automatically generated.
        Hide
        Tamas Sarlos added a comment -

        Re: -1 tests included: MAPREDUCE-1306 introduced a test case, TestRandomSeedGenerator.java. The current patch does not change the API of RandomSeedGenerator.java.

        Show
        Tamas Sarlos added a comment - Re: -1 tests included: MAPREDUCE-1306 introduced a test case, TestRandomSeedGenerator.java. The current patch does not change the API of RandomSeedGenerator.java.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good...

        Show
        Mahadev konar added a comment - +1 the patch looks good...
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks tamas!

        Show
        Mahadev konar added a comment - I just committed this. thanks tamas!
        Hide
        Mahadev konar added a comment -

        fixed only in trunk!

        Show
        Mahadev konar added a comment - fixed only in trunk!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #263 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/263/)
        . [Rumen] Improvements to random seed generation (tamas via mahadev)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #263 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/263/ ) . [Rumen] Improvements to random seed generation (tamas via mahadev)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #285 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/285/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #285 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/285/ )

          People

          • Assignee:
            Tamas Sarlos
            Reporter:
            Tamas Sarlos
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development