Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1578

HadoopArchives.java should not use HarFileSystem.VERSION

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: harchive
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If we upgrade the protocol on HarFileSystem, HadoopArchives might generate an old archive and assign the new version number to it.

      This should be fixed

      1. MAPREDUCE-1578.patch
        0.8 kB
        Rodrigo Schmidt

        Issue Links

          Activity

          Hide
          Rodrigo Schmidt added a comment -

          Simple patch to fix this problem. Really doesn't require extra unit tests.

          Show
          Rodrigo Schmidt added a comment - Simple patch to fix this problem. Really doesn't require extra unit tests.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12438249/MAPREDUCE-1578.patch
          against trunk revision 920250.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/509/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/509/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/509/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/509/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438249/MAPREDUCE-1578.patch against trunk revision 920250. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/509/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/509/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/509/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/509/console This message is automatically generated.
          Hide
          Mahadev konar added a comment -

          +1 the patch looks good. I have been thinking about moving out HarFileSystem to mapreduce and get it into contrib or some seperate tools jar so that its not part of the core release. We might want to do that ASAP. We can commit this for now, but moving it out of core is very essential for folks to use Har!

          Show
          Mahadev konar added a comment - +1 the patch looks good. I have been thinking about moving out HarFileSystem to mapreduce and get it into contrib or some seperate tools jar so that its not part of the core release. We might want to do that ASAP. We can commit this for now, but moving it out of core is very essential for folks to use Har!
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Rodrigo!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Rodrigo!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #270 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/270/)
          . Decouple HadoopArchives vesrion from HarFileSystem version. Contributed by Rodrigo Schmidt

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #270 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/270/ ) . Decouple HadoopArchives vesrion from HarFileSystem version. Contributed by Rodrigo Schmidt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #254 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/254/)
          . Decouple HadoopArchives vesrion from HarFileSystem version. Contributed by Rodrigo Schmidt

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #254 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/254/ ) . Decouple HadoopArchives vesrion from HarFileSystem version. Contributed by Rodrigo Schmidt

            People

            • Assignee:
              Rodrigo Schmidt
              Reporter:
              Rodrigo Schmidt
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development