Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1515

need to pass down java5 and forrest home variables

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, the build script doesn't pass down the variables for java5 and forrest, so the build breaks unless they are on the command line.

      1. MAPREDUCE-1515.patch
        1 kB
        Al Thompson
      2. atx20100224a.patch
        0.9 kB
        Al Thompson
      3. m-1515.patch
        0.4 kB
        Owen O'Malley

        Activity

        Hide
        Owen O'Malley added a comment -

        This patch just passes the variables down to the subant call.

        Show
        Owen O'Malley added a comment - This patch just passes the variables down to the subant call.
        Hide
        Devaraj Das added a comment -

        +1

        Show
        Devaraj Das added a comment - +1
        Hide
        Devaraj Das added a comment -

        Sorry, i didn't mean to resolve it .. smile

        Show
        Devaraj Das added a comment - Sorry, i didn't mean to resolve it .. smile
        Hide
        Al Thompson added a comment -

        This patch allows a local Ant properties file to be read from the imported build file, build-utils.xml. This removes the need to pass properties required by both the top-level and imported build file on the command-line Ant invocation using the -D switch.

        It differs from the previous patch in that the entire contents of the properties file are read in, whereas the previous patch only sets the required properties (java5.home and forrest.home) based on their settings in the top-level build script. If any other properties are later needed these will need to be added into the imported build script (i.e., build-utils.xml).

        This patch only reads the build.properties from the local directory (the hadoop-mapreduce root directory). This differs from the top-level Ant file which also will look for build properties in the user's home directory.

        Show
        Al Thompson added a comment - This patch allows a local Ant properties file to be read from the imported build file, build-utils.xml. This removes the need to pass properties required by both the top-level and imported build file on the command-line Ant invocation using the -D switch. It differs from the previous patch in that the entire contents of the properties file are read in, whereas the previous patch only sets the required properties (java5.home and forrest.home) based on their settings in the top-level build script. If any other properties are later needed these will need to be added into the imported build script (i.e., build-utils.xml). This patch only reads the build.properties from the local directory (the hadoop-mapreduce root directory). This differs from the top-level Ant file which also will look for build properties in the user's home directory.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12436907/atx20100224a.patch
        against trunk revision 915223.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/483/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/483/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/483/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/483/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12436907/atx20100224a.patch against trunk revision 915223. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/483/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/483/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/483/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/483/console This message is automatically generated.
        Hide
        Owen O'Malley added a comment -

        Al, Can you just delete the line out of build-utils.xml instead of commenting it out? Other than that, either solution is fine.

        Show
        Owen O'Malley added a comment - Al, Can you just delete the line out of build-utils.xml instead of commenting it out? Other than that, either solution is fine.
        Hide
        Al Thompson added a comment -

        This revision of the patch cleans dead wood comments from the patch as Owen suggested, and adjusted error messages to indicate a property can be set at Ant command line or in build properties file.

        Show
        Al Thompson added a comment - This revision of the patch cleans dead wood comments from the patch as Owen suggested, and adjusted error messages to indicate a property can be set at Ant command line or in build properties file.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12439536/MAPREDUCE-1515.patch
        against trunk revision 926449.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/50/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/50/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/50/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/50/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439536/MAPREDUCE-1515.patch against trunk revision 926449. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/50/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/50/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/50/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/50/console This message is automatically generated.
        Hide
        Chris Douglas added a comment -

        +1

        I committed this. Thanks, Al!

        Show
        Chris Douglas added a comment - +1 I committed this. Thanks, Al!
        Hide
        Jeremy Carroll added a comment -

        +1

        Just patched my version of CDH3 Beta 3, and tried to recreate this issue. I could not. The patch looks good to me.

        Show
        Jeremy Carroll added a comment - +1 Just patched my version of CDH3 Beta 3, and tried to recreate this issue. I could not. The patch looks good to me.
        Hide
        Konstantin Boudnik added a comment -
        Show
        Konstantin Boudnik added a comment -

          People

          • Assignee:
            Al Thompson
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development