Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1508

NPE in TestMultipleLevelCaching on error cleanup path

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestMultipleLevelCaching dereferences objects in a finally block which may not have been initialized.

      1. MAPREDUCE-1508.patch
        0.8 kB
        Aaron Kimball

        Activity

        Hide
        Aaron Kimball added a comment -

        An IOException when initializing MiniDFSCluster in in testCachingAtLevel() will cause a NPE to occur in the finally block, when dereferencing the FileSystem object. Attached is a patch that guards this case.

        Show
        Aaron Kimball added a comment - An IOException when initializing MiniDFSCluster in in testCachingAtLevel() will cause a NPE to occur in the finally block, when dereferencing the FileSystem object. Attached is a patch that guards this case.
        Hide
        Amareshwari Sriramadasu added a comment -

        +1 Patch looks fine.

        Show
        Amareshwari Sriramadasu added a comment - +1 Patch looks fine.
        Hide
        Chris Douglas added a comment -

        +1

        I committed this. Thanks, Aaron!

        Show
        Chris Douglas added a comment - +1 I committed this. Thanks, Aaron!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #286 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/286/)
        . Protect against NPE in TestMultipleLevelCaching. Contributed by Aaron Kimball

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #286 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/286/ ) . Protect against NPE in TestMultipleLevelCaching. Contributed by Aaron Kimball
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #264 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/264/)
        . Protect against NPE in TestMultipleLevelCaching. Contributed by Aaron Kimball

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #264 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/264/ ) . Protect against NPE in TestMultipleLevelCaching. Contributed by Aaron Kimball

          People

          • Assignee:
            Aaron Kimball
            Reporter:
            Aaron Kimball
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development