Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1497

Suppress warning on inconsistent TaskTracker.indexCache synchronization

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: tasktracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Findbugs warns that TaskTracker.indexCache is incorrectly synchronized.
      It is not accessed synchronously from MapOutputServlet.doGet, TaskCleanupThread and TaskTracker.killOverflowingTasks() method. Other callers access it synchronously.

      1. patch-1497.txt
        0.7 kB
        Amareshwari Sriramadasu

        Activity

        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12314045 ]
        Fix Version/s 0.22.0 [ 12314184 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #264 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/264/)
        . Suppress spurious findbugs warning about IndexCache
        synchronization. Contributed by Amareshwari Sriramadasu

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #264 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/264/ ) . Suppress spurious findbugs warning about IndexCache synchronization. Contributed by Amareshwari Sriramadasu
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #287 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/287/)
        . Suppress spurious findbugs warning about IndexCache
        synchronization. Contributed by Amareshwari Sriramadasu

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #287 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/287/ ) . Suppress spurious findbugs warning about IndexCache synchronization. Contributed by Amareshwari Sriramadasu
        Chris Douglas made changes -
        Summary TaskTracker.indexCache is incorrectly synchronized Suppress warning on inconsistent TaskTracker.indexCache synchronization
        Assignee Amareshwari Sriramadasu [ amareshwari ]
        Description TaskTracker.indexCache is incorrectly synchronized.
        It is not accessed synchronously from MapOutputServlet.doGet, TaskCleanupThread and TaskTracker.killOverflowingTasks() method. Other callers access it synchronously.
        Findbugs warns that TaskTracker.indexCache is incorrectly synchronized.
        It is not accessed synchronously from MapOutputServlet.doGet, TaskCleanupThread and TaskTracker.killOverflowingTasks() method. Other callers access it synchronously.
        Chris Douglas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Chris Douglas added a comment -

        I committed this. Thanks, Amareshwari!

        Show
        Chris Douglas added a comment - I committed this. Thanks, Amareshwari!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12435966/patch-1497.txt
        against trunk revision 910465.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/456/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/456/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/456/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/456/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435966/patch-1497.txt against trunk revision 910465. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/456/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/456/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/456/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/456/console This message is automatically generated.
        Amareshwari Sriramadasu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Amareshwari Sriramadasu made changes -
        Field Original Value New Value
        Attachment patch-1497.txt [ 12435966 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        If it is thread-safe, I think we can suppress the findbugs warning for inconsistent synchronization of IndexCache.
        Attaching patch doing the same.

        Show
        Amareshwari Sriramadasu added a comment - If it is thread-safe, I think we can suppress the findbugs warning for inconsistent synchronization of IndexCache. Attaching patch doing the same.
        Hide
        Chris Douglas added a comment -

        IndexCache is threadsafe. Any synchronization should be for the protection of other data structures in the block.

        Show
        Chris Douglas added a comment - IndexCache is threadsafe. Any synchronization should be for the protection of other data structures in the block.
        Amareshwari Sriramadasu created issue -

          People

          • Assignee:
            Amareshwari Sriramadasu
            Reporter:
            Amareshwari Sriramadasu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development