Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1440

MapReduce should use the short form of the user names

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      To minimize disruption on MapReduce, we should use the local names (ie. "omalley") rather than the long names (ie. "omalley@APACHE.ORG" as the basis for the username in MapReduce.

      1. 1440.y20.patch
        12 kB
        Devaraj Das
      2. m-1440.patch
        11 kB
        Owen O'Malley

        Activity

        Hide
        Allen Wittenauer added a comment -

        What happens in a cross-realm situation when there are multiple realms involved?

        Show
        Allen Wittenauer added a comment - What happens in a cross-realm situation when there are multiple realms involved?
        Hide
        Owen O'Malley added a comment -

        The multi-realm case is why we need the mapping. MapReduce needs a unique local username to run the processes as. The local name is the user that the task runs as and determines the groups. Any authentication names that merge into a single local username, need to be the same person.

        Show
        Owen O'Malley added a comment - The multi-realm case is why we need the mapping. MapReduce needs a unique local username to run the processes as. The local name is the user that the task runs as and determines the groups. Any authentication names that merge into a single local username, need to be the same person.
        Hide
        Allen Wittenauer added a comment -

        Oooo. I see what you mean by 'local names' now. I was thinking you were just going to chop off the contents after the @.

        Show
        Allen Wittenauer added a comment - Oooo. I see what you mean by 'local names' now. I was thinking you were just going to chop off the contents after the @.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12434589/m-1440.patch
        against trunk revision 906228.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/299/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/299/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/299/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/299/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12434589/m-1440.patch against trunk revision 906228. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/299/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/299/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/299/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/299/console This message is automatically generated.
        Hide
        Owen O'Malley added a comment -

        It isn't possible to write a unit test since the API doesn't expose the user.

        The contrib tests failed because of HADOOP-6538.

        Show
        Owen O'Malley added a comment - It isn't possible to write a unit test since the API doesn't expose the user. The contrib tests failed because of HADOOP-6538 .
        Hide
        Devaraj Das added a comment -

        +1

        Show
        Devaraj Das added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12434589/m-1440.patch
        against trunk revision 906228.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/302/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/302/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/302/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/302/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12434589/m-1440.patch against trunk revision 906228. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/302/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/302/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/302/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/302/console This message is automatically generated.
        Hide
        Devaraj Das added a comment -

        Just a note that this patch doesn't address the testcases. Should we address the testcases to use short names too? I am okay either way - we can fix the testcases in a separate jira..

        Show
        Devaraj Das added a comment - Just a note that this patch doesn't address the testcases. Should we address the testcases to use short names too? I am okay either way - we can fix the testcases in a separate jira..
        Hide
        Owen O'Malley added a comment -

        As I commented previously, the user name is not exposed by our api. I don't see how to write a test case without adding a lot of new access methods.

        Show
        Owen O'Malley added a comment - As I commented previously, the user name is not exposed by our api. I don't see how to write a test case without adding a lot of new access methods.
        Hide
        Devaraj Das added a comment -

        Yeah, ignore my previous comment. +1 on the latest patch.

        Show
        Devaraj Das added a comment - Yeah, ignore my previous comment. +1 on the latest patch.
        Hide
        Owen O'Malley added a comment -

        I just committed this.

        Show
        Owen O'Malley added a comment - I just committed this.
        Hide
        Devaraj Das added a comment -

        Attaching patch for the Y20 distribution. Not to be committed.

        Show
        Devaraj Das added a comment - Attaching patch for the Y20 distribution. Not to be committed.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #228 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/228/)
        . Replace the long user name in MapReduce with the local
        name. (omalley)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #228 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/228/ ) . Replace the long user name in MapReduce with the local name. (omalley)

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development