Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1399

The archive command shows a null error message

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: harchive
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      bash-3.1$ hadoop archive -archiveName foo.har -p . foo .
      Exception in archives
      null
      
      1. MAPREDUCE-1399.patch
        7 kB
        Mahadev konar
      2. m1399_20100204.patch
        0.7 kB
        Tsz Wo Nicholas Sze
      3. m1399_20100205.patch
        1 kB
        Tsz Wo Nicholas Sze
      4. m1399_20100205trunk.patch
        2 kB
        Tsz Wo Nicholas Sze
      5. m1399_20100205trunk2.patch
        3 kB
        Tsz Wo Nicholas Sze
      6. m1399_20100205trunk2_y0.20.patch
        1 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        Also, the doc (hadoop_archives.xml) is out-dated. It does not mention the -p option.

        Show
        Tsz Wo Nicholas Sze added a comment - Also, the doc (hadoop_archives.xml) is out-dated. It does not mention the -p option.
        Hide
        Mahadev konar added a comment -

        this patch includes the doc changes that went missing because of the split and docs removed from common which should have been moved to mapreduce.

        Show
        Mahadev konar added a comment - this patch includes the doc changes that went missing because of the split and docs removed from common which should have been moved to mapreduce.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        It is not clear about the file permission of har in the doc. We should clarify that

        • the original file permissions will be lost, and
        • the required permission setting in order to share har to other users
        Show
        Tsz Wo Nicholas Sze added a comment - It is not clear about the file permission of har in the doc. We should clarify that the original file permissions will be lost, and the required permission setting in order to share har to other users
        Hide
        Tsz Wo Nicholas Sze added a comment -

        m1399_20100204.patch: check null before printing.

        Show
        Tsz Wo Nicholas Sze added a comment - m1399_20100204.patch: check null before printing.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        After applied m1399_20100204.patch, it shows a NPE for the following.

        -bash-3.1$ hadoop archive -archiveName foo.har -p . foo .
        Exception in archives
        java.lang.NullPointerException
                at org.apache.hadoop.tools.HadoopArchives.run(HadoopArchives.java:733)
                at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
                at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:79)
                at org.apache.hadoop.tools.HadoopArchives.main(HadoopArchives.java:752)
        

        Here is the codes:

        732        FileStatus[] statuses = fs.globStatus(p);
        733        for (FileStatus status: statuses) {
        734           globPaths.add(fs.makeQualified(status.getPath()));
        735        }
        
        Show
        Tsz Wo Nicholas Sze added a comment - After applied m1399_20100204.patch, it shows a NPE for the following. -bash-3.1$ hadoop archive -archiveName foo.har -p . foo . Exception in archives java.lang.NullPointerException at org.apache.hadoop.tools.HadoopArchives.run(HadoopArchives.java:733) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:79) at org.apache.hadoop.tools.HadoopArchives.main(HadoopArchives.java:752) Here is the codes: 732 FileStatus[] statuses = fs.globStatus(p); 733 for (FileStatus status: statuses) { 734 globPaths.add(fs.makeQualified(status.getPath())); 735 }
        Hide
        Tsz Wo Nicholas Sze added a comment -

        m1399_20100205.patch: also fixed NPE.

        Show
        Tsz Wo Nicholas Sze added a comment - m1399_20100205.patch: also fixed NPE.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        m1399_20100205trunk.patch: added a test.

        Show
        Tsz Wo Nicholas Sze added a comment - m1399_20100205trunk.patch: added a test.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        m1399_20100205trunk2.patch: one of the existing test actually expecting NullPointerException. Changed it.

        Show
        Tsz Wo Nicholas Sze added a comment - m1399_20100205trunk2.patch: one of the existing test actually expecting NullPointerException. Changed it.
        Hide
        Mahadev konar added a comment -

        +1 the patch looks good.

        Show
        Mahadev konar added a comment - +1 the patch looks good.
        Hide
        Mahadev konar added a comment -

        result of ant test-patch on my machine:

             [exec]
             [exec]
             [exec]
             [exec] +1 overall.
             [exec]
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]
             [exec]     +1 tests included.  The patch appears to include 7 new or modified tests.
             [exec]
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec]
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec]
             [exec]
             [exec]
             [exec]
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]     Finished build.
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]
             [exec]
        
        BUILD SUCCESSFUL
        Total time: 26 minutes 20 seconds
        
        Show
        Mahadev konar added a comment - result of ant test-patch on my machine: [exec] [exec] [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 7 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] BUILD SUCCESSFUL Total time: 26 minutes 20 seconds
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Hudson does not seem working. Ran test-patch locally.

             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no new tests are needed for this patch.
             [exec]                         Also please list what manual steps were performed to verify this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec] 
        
        Show
        Tsz Wo Nicholas Sze added a comment - Hudson does not seem working. Ran test-patch locally. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Oops, I mistakenly posted the test-patch result for MAPREDUCE-1425 to this. Sorry ...

        Show
        Tsz Wo Nicholas Sze added a comment - Oops, I mistakenly posted the test-patch result for MAPREDUCE-1425 to this. Sorry ...
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12435047/m1399_20100205trunk2.patch
        against trunk revision 907967.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/304/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/304/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/304/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/304/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435047/m1399_20100205trunk2.patch against trunk revision 907967. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/304/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/304/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/304/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/304/console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12435047/m1399_20100205trunk2.patch
        against trunk revision 907967.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/438/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/438/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/438/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/438/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435047/m1399_20100205trunk2.patch against trunk revision 907967. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/438/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/438/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/438/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/438/console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        m1399_20100205trunk2_y0.20.patch: for y0.20

        Show
        Tsz Wo Nicholas Sze added a comment - m1399_20100205trunk2_y0.20.patch: for y0.20
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks nicholas.

        Show
        Mahadev konar added a comment - I just committed this. thanks nicholas.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #233 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/233/)
        . The archive command shows a null error message (nicholas via mahadev)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #233 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/233/ ) . The archive command shows a null error message (nicholas via mahadev)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #232 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/232/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #232 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/232/ )

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development