Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.20.2
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fix a misleading exception message in case the Chained Mappers have mismatch in input/output Key/Value pairs between them.

      Description

      Hi,
      I was using the Chain[Mapper/Reducer] APIs , and in Class Chain line 207 the error thrown :

      "The Mapper output key class does not match the previous Mapper input key class"

      Shouldn't this be "The Mapper input key class does not match the previous Mapper Output key class" ? Sort of misleads

      1. MAPREDUCE-1242.r2.patch
        1 kB
        Harsh J
      2. MAPREDUCE-1242.patch
        0.9 kB
        Harsh J

        Activity

        Hide
        Harsh J added a comment -

        Attached a patch fixing the said misleading string.

        Show
        Harsh J added a comment - Attached a patch fixing the said misleading string.
        Hide
        Amareshwari Sriramadasu added a comment -

        The same holds for value class validation also. Harsh, Can you update the patch for value class also?

        Show
        Amareshwari Sriramadasu added a comment - The same holds for value class validation also. Harsh, Can you update the patch for value class also?
        Hide
        Harsh J added a comment -

        New patch that adds in the other pointer as requested by Amareshwari. Hope this clears up the doc issue.

        Show
        Harsh J added a comment - New patch that adds in the other pointer as requested by Amareshwari. Hope this clears up the doc issue.
        Hide
        Harsh J added a comment -

        Patch available that fixes this minor docs issue.

        Show
        Harsh J added a comment - Patch available that fixes this minor docs issue.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12468867/MAPREDUCE-1242.r2.patch
        against trunk revision 1075216.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/89//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/89//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/89//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468867/MAPREDUCE-1242.r2.patch against trunk revision 1075216. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/89//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/89//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/89//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        Just change of strings in an exception message. No test cases should be required for that.

        Show
        Harsh J added a comment - Just change of strings in an exception message. No test cases should be required for that.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Harsh!

        Show
        Tom White added a comment - I've just committed this. Thanks Harsh!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #631 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/631/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #631 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/631/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )

          People

          • Assignee:
            Harsh J
            Reporter:
            Amogh Vasekar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development