Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1161

NotificationTestCase should not lock current thread

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are 3 instances where NotificationTestCase is locking Thread.currentThread() is being locked and calling sleep on it. There is also a method stdPrintln that doesn't do anything.

      1. mr-1161.patch
        3 kB
        Owen O'Malley

        Activity

        Hide
        Owen O'Malley added a comment -

        This patch just cleans up the test to remove the unnecessary synchronization and the print method that had a commented out println.

        Show
        Owen O'Malley added a comment - This patch just cleans up the test to remove the unnecessary synchronization and the print method that had a commented out println.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423512/mr-1161.patch
        against trunk revision 831037.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/104/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/104/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/104/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423512/mr-1161.patch against trunk revision 831037. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/104/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/104/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/104/console This message is automatically generated.
        Hide
        Chris Douglas added a comment -

        +1

        Show
        Chris Douglas added a comment - +1
        Hide
        Chris Douglas added a comment -

        I committed this. Thanks, Owen!

        Show
        Chris Douglas added a comment - I committed this. Thanks, Owen!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #144 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/144/)
        . Remove ineffective synchronization in NotificationTestCase.
        Contributed by Owen O'Malley

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #144 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/144/ ) . Remove ineffective synchronization in NotificationTestCase. Contributed by Owen O'Malley
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #164 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/164/)
        . Remove ineffective synchronization in NotificationTestCase.
        Contributed by Owen O'Malley

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #164 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/164/ ) . Remove ineffective synchronization in NotificationTestCase. Contributed by Owen O'Malley

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development