Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1159

Limit Job name on jobtracker.jsp to be 80 char long

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0, 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Job names on jobtracker.jsp should be 80 characters long at most.

      Description

      Sometimes a user submits a job with a very long job name. That made jobtracker.jsp very hard to read.
      We should limit the size of the job name. User can see the full name when they click on the job.

      1. MAPREDUCE-1159.trunk.patch
        3 kB
        Zheng Shao
      2. MAPREDUCE-1159.r1.patch
        2 kB
        Harsh J
      3. MAPREDUCE-1159.r2.patch
        2 kB
        Harsh J

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-22-branch #38 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/38/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #38 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/38/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #616 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/616/)
        MAPREDUCE-1159. Limit Job name in web UI to be 80 char long. Contributed by Harsh J Chouraria

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #616 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/616/ ) MAPREDUCE-1159 . Limit Job name in web UI to be 80 char long. Contributed by Harsh J Chouraria
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Harsh!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Harsh!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12451667/MAPREDUCE-1159.r2.patch
        against trunk revision 1075216.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/91//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/91//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/91//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12451667/MAPREDUCE-1159.r2.patch against trunk revision 1075216. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/91//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/91//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/91//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > ... but I'm stumped as to why the TestClusterMapReduceTestCase (Age 1) would fail for this moderately trivial patch.

        I guess the test failure is nothing to do with your patch. Let try one more time.

        Show
        Tsz Wo Nicholas Sze added a comment - > ... but I'm stumped as to why the TestClusterMapReduceTestCase (Age 1) would fail for this moderately trivial patch. I guess the test failure is nothing to do with your patch. Let try one more time.
        Hide
        Harsh J added a comment -

        I can add in a test case for the shortener, but I'm stumped as to why the TestClusterMapReduceTestCase (Age 1) would fail for this moderately trivial patch.

        Show
        Harsh J added a comment - I can add in a test case for the shortener, but I'm stumped as to why the TestClusterMapReduceTestCase (Age 1) would fail for this moderately trivial patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12451667/MAPREDUCE-1159.r2.patch
        against trunk revision 1069255.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.mapred.TestClusterMapReduceTestCase

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/25//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/25//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/25//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12451667/MAPREDUCE-1159.r2.patch against trunk revision 1069255. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.mapred.TestClusterMapReduceTestCase -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/25//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/25//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/25//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        A patch is available. Forgot to mark as so.

        Show
        Harsh J added a comment - A patch is available. Forgot to mark as so.
        Hide
        Harsh J added a comment -

        Forgot about the retired page. Here's an update changing that as well.

        Show
        Harsh J added a comment - Forgot about the retired page. Here's an update changing that as well.
        Hide
        Harsh J added a comment -

        Attaching a fresh patch that applies cleanly to the trunk. Using the 'title' attribute for the hover-text for the table cell (job name).

        Wasn't able to test this live: any ideas on how to start up a mock cluster to see web ui changes, or do I have to deploy it like a normal pseudo one?

        Show
        Harsh J added a comment - Attaching a fresh patch that applies cleanly to the trunk. Using the 'title' attribute for the hover-text for the table cell (job name). Wasn't able to test this live: any ideas on how to start up a mock cluster to see web ui changes, or do I have to deploy it like a normal pseudo one?
        Hide
        Chris Douglas added a comment -

        Canceling patch while Nicholas's comments are addressed

        Show
        Chris Douglas added a comment - Canceling patch while Nicholas's comments are addressed
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > ... are you saying that if the user hovers the mouse above the jobname, then the full name of the job show up?

        Exactly.

        >> Should we make the limit configurable?
        >
        > We can, but do you really need it to be configurable? It will be yet another knob to turn for the user.

        I don't need it but some users may prefer a smaller limit, especially if we have alt-text showing the full name. We may implement this later.

        BTW, I think we should have

            return name.length() > 80? name.substring(0,76) + "..." : name;
        

        in getAbbreviatedJobName(..). If (76 < name.length() <= 80), we don't want to replace the last few characters with "...".

        Show
        Tsz Wo Nicholas Sze added a comment - > ... are you saying that if the user hovers the mouse above the jobname, then the full name of the job show up? Exactly. >> Should we make the limit configurable? > > We can, but do you really need it to be configurable? It will be yet another knob to turn for the user. I don't need it but some users may prefer a smaller limit, especially if we have alt-text showing the full name. We may implement this later. BTW, I think we should have return name.length() > 80? name.substring(0,76) + "..." : name; in getAbbreviatedJobName(..). If (76 < name.length() <= 80), we don't want to replace the last few characters with "...".
        Hide
        dhruba borthakur added a comment -

        > Should we make the limit configurable?

        We can, but do you really need it to be configurable? It will be yet another knob to turn for the user.

        > good if the original job name will be displayed as an alt-text.

        sounds like an excellent idea. are you saying that if the user hovers the mouse above the jobname, then the full name of the job show up?

        Show
        dhruba borthakur added a comment - > Should we make the limit configurable? We can, but do you really need it to be configurable? It will be yet another knob to turn for the user. > good if the original job name will be displayed as an alt-text. sounds like an excellent idea. are you saying that if the user hovers the mouse above the jobname, then the full name of the job show up?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Should we make the limit configurable? Also, I think it would be good if the original job name will be displayed as an alt-text. Otherwise, we cannot tell the difference if two jobs share the same prefix.

        Show
        Tsz Wo Nicholas Sze added a comment - Should we make the limit configurable? Also, I think it would be good if the original job name will be displayed as an alt-text. Otherwise, we cannot tell the difference if two jobs share the same prefix.
        Hide
        Amar Kamat added a comment -

        +1. The job filtering using job-name on jobtracker.jsp now might result into multiple options (since display name is shorter than the actual name and search is done on display name). But I think its fine.

        Show
        Amar Kamat added a comment - +1. The job filtering using job-name on jobtracker.jsp now might result into multiple options (since display name is shorter than the actual name and search is done on display name). But I think its fine.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423420/MAPREDUCE-1159.trunk.patch
        against trunk revision 829529.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/96/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/96/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/96/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/96/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423420/MAPREDUCE-1159.trunk.patch against trunk revision 829529. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/96/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/96/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/96/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/96/console This message is automatically generated.
        Hide
        Zheng Shao added a comment -

        Extracted common code.

        Show
        Zheng Shao added a comment - Extracted common code.
        Hide
        Amar Kamat added a comment -

        Zheng,
        Why dont you common out the code to do with trimming (say in trimJobName(String))?

        Show
        Amar Kamat added a comment - Zheng, Why dont you common out the code to do with trimming (say in trimJobName(String))?
        Hide
        dhruba borthakur added a comment -

        code looks good. +1.

        Show
        dhruba borthakur added a comment - code looks good. +1.

          People

          • Assignee:
            Harsh J
            Reporter:
            Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development