Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1153

Metrics counting tasktrackers and blacklisted tasktrackers are not updated when trackers are decommissioned.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: jobtracker
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Update the number of trackers and blacklisted trackers metrics when trackers are decommissioned.

      Description

      MAPREDUCE-1103 added instrumentation on the jobtracker to count the number of actual, blacklisted and decommissioned tasktrackers. When a tracker is decommissioned, the tasktracker count or the blacklisted tracker count is not decremented.

      1. 1153.patch
        4 kB
        Sharad Agarwal

        Activity

        Hide
        Sharad Agarwal added a comment -

        Moved common code into a single method - removeTracker(TaskTracker)

        Show
        Sharad Agarwal added a comment - Moved common code into a single method - removeTracker(TaskTracker)
        Hide
        Amareshwari Sriramadasu added a comment -

        changes look fine. Submitting for hudson

        Show
        Amareshwari Sriramadasu added a comment - changes look fine. Submitting for hudson
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423172/1153.patch
        against trunk revision 829529.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/93/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/93/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/93/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/93/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423172/1153.patch against trunk revision 829529. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/93/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/93/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/93/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/93/console This message is automatically generated.
        Hide
        Sharad Agarwal added a comment -

        Test failure is due to MAPREDUCE-1124

        Show
        Sharad Agarwal added a comment - Test failure is due to MAPREDUCE-1124
        Hide
        Sharad Agarwal added a comment -

        I just committed this.

        Show
        Sharad Agarwal added a comment - I just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #103 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/103/)
        . Fix tasktracker metrics when trackers are decommissioned. Contributed by Sharad Agarwal.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #103 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/103/ ) . Fix tasktracker metrics when trackers are decommissioned. Contributed by Sharad Agarwal.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #133 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/133/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #133 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/133/ )

          People

          • Assignee:
            Sharad Agarwal
            Reporter:
            Hemanth Yamijala
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development