Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      See HADOOP-6309. Let's make the tests run with java asserts by default.

      1. hadoop6309-mapreduce.patch
        0.5 kB
        Eli Collins
      2. M1092-1.patch
        7 kB
        Chris Douglas
      3. M1092-2.patch
        7 kB
        Chris Douglas

        Issue Links

          Activity

          Eli Collins created issue -
          Eli Collins made changes -
          Field Original Value New Value
          Attachment hadoop6309-mapreduce.patch [ 12421910 ]
          Hide
          Eli Collins added a comment -

          Two java asserts in tests fail when running with this patch, filed MAPREDUCE-1093 for them. TestCopyFiles also failed, but that's MAPREDUCE-1029.

          Show
          Eli Collins added a comment - Two java asserts in tests fail when running with this patch, filed MAPREDUCE-1093 for them. TestCopyFiles also failed, but that's MAPREDUCE-1029 .
          Eli Collins made changes -
          Link This issue is blocked by MAPREDUCE-1093 [ MAPREDUCE-1093 ]
          Aaron Kimball made changes -
          Link This issue is related to MAPREDUCE-1506 [ MAPREDUCE-1506 ]
          Hide
          Aaron Kimball added a comment -

          Per Vinod's comment on MAPREDUCE-1093, can we resolve this now, so as to include assertion checking on trunk by default? I'm going to mark the patch as available.

          Show
          Aaron Kimball added a comment - Per Vinod's comment on MAPREDUCE-1093 , can we resolve this now, so as to include assertion checking on trunk by default? I'm going to mark the patch as available.
          Aaron Kimball made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Vinod Kumar Vavilapalli added a comment -

          can we resolve this now?

          +1 assuming Hudson blesses it. If Hudson itself hits MAPREDUCE-1506, we will need to fix that first. I see that you have attached a failure trace there, I'll start digging into it.

          Show
          Vinod Kumar Vavilapalli added a comment - can we resolve this now? +1 assuming Hudson blesses it. If Hudson itself hits MAPREDUCE-1506 , we will need to fix that first. I see that you have attached a failure trace there, I'll start digging into it.
          Vinod Kumar Vavilapalli made changes -
          Fix Version/s 0.22.0 [ 12314184 ]
          Component/s test [ 12312904 ]
          Hide
          Aaron Kimball added a comment -

          I'll point out that MAPREDUCE-1506 is intermittent; I hit this roughly 90% of the time on my own machine, but I think it's a race condition of some sort. There are times when back-to-back tests do not trigger a reproduction. It might not manifest on Hudson at all on the first pass, but that's no guarantee either way for subsequent runs.

          Show
          Aaron Kimball added a comment - I'll point out that MAPREDUCE-1506 is intermittent; I hit this roughly 90% of the time on my own machine, but I think it's a race condition of some sort. There are times when back-to-back tests do not trigger a reproduction. It might not manifest on Hudson at all on the first pass, but that's no guarantee either way for subsequent runs.
          Chris Douglas made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Chris Douglas made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch
          against trunk revision 925554.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch against trunk revision 925554. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/44/console This message is automatically generated.
          Aaron Kimball made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Aaron Kimball made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch
          against trunk revision 926411.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch against trunk revision 926411. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/48/console This message is automatically generated.
          Chris Douglas made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Chris Douglas made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch
          against trunk revision 940740.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421910/hadoop6309-mapreduce.patch against trunk revision 940740. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/532/console This message is automatically generated.
          Hide
          Chris Douglas added a comment -

          This shouldn't be blocked on MAPREDUCE-1506. I propose disabling the failing tests in trunk for now and mark MAPREDUCE-1506 as a blocker in trunk. Sound fair?

          Show
          Chris Douglas added a comment - This shouldn't be blocked on MAPREDUCE-1506 . I propose disabling the failing tests in trunk for now and mark MAPREDUCE-1506 as a blocker in trunk. Sound fair?
          Chris Douglas made changes -
          Attachment M1092-1.patch [ 12443764 ]
          Chris Douglas made changes -
          Assignee Eli Collins [ eli ]
          Hide
          Eli Collins added a comment -

          Sounds good to me.

          Show
          Eli Collins added a comment - Sounds good to me.
          Hide
          Chris Douglas added a comment -

          Made a property of the junit args.

          Show
          Chris Douglas added a comment - Made a property of the junit args.
          Chris Douglas made changes -
          Attachment M1092-2.patch [ 12443772 ]
          Hide
          Chris Douglas added a comment -

          +1

          I committed this. Thanks, Eli!

          Show
          Chris Douglas added a comment - +1 I committed this. Thanks, Eli!
          Chris Douglas made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Eli Collins added a comment -

          +1 on M1092-2.patch. Thanks Chris!

          Show
          Eli Collins added a comment - +1 on M1092-2.patch. Thanks Chris!
          Eli Collins made changes -
          Link This issue relates to HADOOP-6309 [ HADOOP-6309 ]
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          75d 3h 37m 3 Chris Douglas 05/May/10 03:57
          Open Open Patch Available Patch Available
          129d 1h 55m 4 Chris Douglas 05/May/10 03:58
          Patch Available Patch Available Resolved Resolved
          18h 38m 1 Chris Douglas 05/May/10 22:36
          Resolved Resolved Closed Closed
          585d 8h 43m 1 Konstantin Shvachko 12/Dec/11 06:19

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development