Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1077

When rumen reads a truncated job tracker log, it produces a job whose outcome is SUCCESS. Should be null.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: tools/rumen
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      Dick King added a comment -

      This patch looks huge, but most of it is deletions .

      Show
      Dick King added a comment - This patch looks huge, but most of it is deletions .
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12422117/mapreduce-1077--2009-10-14.patch
      against trunk revision 825083.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 9 new or modified tests.

      -1 patch. The patch command could not apply the patch.

      Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/168/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422117/mapreduce-1077--2009-10-14.patch against trunk revision 825083. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/168/console This message is automatically generated.
      Hide
      Dick King added a comment -

      this patch will be replaced

      Show
      Dick King added a comment - this patch will be replaced
      Hide
      Dick King added a comment -

      This patch will flunk audit because it has binary files which will not have an ASF header. Please accept that.

      Show
      Dick King added a comment - This patch will flunk audit because it has binary files which will not have an ASF header. Please accept that.
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12422393/mapreduce-1077--2009-10-16.patch
      against trunk revision 825469.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 11 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/177/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/177/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/177/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/177/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422393/mapreduce-1077--2009-10-16.patch against trunk revision 825469. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/177/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/177/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/177/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/177/console This message is automatically generated.
      Hide
      Hong Tang added a comment -

      The patch looks good. +1.

      You probably also want to mention a couple of minor changes introduced by the patch:

      • Replaced the original testcase data files with gzipped version.
      • Added AnySetters for a few LoggedXXX classes to ensure backward compatibility.
      Show
      Hong Tang added a comment - The patch looks good. +1. You probably also want to mention a couple of minor changes introduced by the patch: Replaced the original testcase data files with gzipped version. Added AnySetters for a few LoggedXXX classes to ensure backward compatibility.
      Hide
      Chris Douglas added a comment -

      I committed this. Thanks, Dick!

      Show
      Chris Douglas added a comment - I committed this. Thanks, Dick!
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk-Commit #82 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/82/)
      . Fix Rumen so that truncated tasks do not mark the job as
      successful. Contributed by Dick King

      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #82 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/82/ ) . Fix Rumen so that truncated tasks do not mark the job as successful. Contributed by Dick King
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #117 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/117/)
      . Fix Rumen so that truncated tasks do not mark the job as
      successful. Contributed by Dick King

      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #117 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/117/ ) . Fix Rumen so that truncated tasks do not mark the job as successful. Contributed by Dick King

        People

        • Assignee:
          Dick King
          Reporter:
          Dick King
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development