Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1071

o.a.h.mapreduce.jobhistory.EventReader constructor should expect DataInputStream

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      o.a.h.mapreduce.jobhistory.EventReader constructor should expect DataInputStream, so that it can parse job histories that are aggregated or compressed in file containers such as TFile.

      1. mapreduce-1071.patch
        1 kB
        Hong Tang
      2. mapreduce-1071-2.patch
        1 kB
        Hong Tang
      3. mapreduce-1071-3.patch
        2 kB
        Hong Tang

        Activity

        Hong Tang created issue -
        Hide
        Hong Tang added a comment -

        Very trivial patch.

        Show
        Hong Tang added a comment - Very trivial patch.
        Hong Tang made changes -
        Field Original Value New Value
        Attachment mapreduce-1071.patch [ 12421499 ]
        Hide
        Hong Tang added a comment -

        Removed an unused import.

        Show
        Hong Tang added a comment - Removed an unused import.
        Hong Tang made changes -
        Attachment mapreduce-1071-2.patch [ 12421500 ]
        Hide
        Hong Tang added a comment -

        Change only affected the interface, no tests needed.

        Show
        Hong Tang added a comment - Change only affected the interface, no tests needed.
        Hong Tang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hong Tang added a comment -

        Also make EventReader implement Closeable.

        Show
        Hong Tang added a comment - Also make EventReader implement Closeable.
        Hong Tang made changes -
        Attachment mapreduce-1071-3.patch [ 12421501 ]
        Hide
        Jothi Padmanabhan added a comment -

        Makes sense. Patch looks good.

        Show
        Jothi Padmanabhan added a comment - Makes sense. Patch looks good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12421500/mapreduce-1071-2.patch
        against trunk revision 819740.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/145/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/145/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/145/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/145/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421500/mapreduce-1071-2.patch against trunk revision 819740. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/145/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/145/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/145/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/145/console This message is automatically generated.
        Hide
        Doug Cutting added a comment -

        +1 looks good to me.

        Show
        Doug Cutting added a comment - +1 looks good to me.
        Hide
        Chris Douglas added a comment -

        Any objection to committing this to 0.21?

        Show
        Chris Douglas added a comment - Any objection to committing this to 0.21?
        Chris Douglas made changes -
        Assignee Hong Tang [ hong.tang ]
        Hide
        Chris Douglas added a comment -

        I committed this. Thanks, Hong!

        Show
        Chris Douglas added a comment - I committed this. Thanks, Hong!
        Chris Douglas made changes -
        Fix Version/s 0.21.0 [ 12314045 ]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #74 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/74/)
        . Use DataInputStream rather than FSDataInputStream in the
        JobHistory EventReader. Contributed by Hong Tang

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #74 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/74/ ) . Use DataInputStream rather than FSDataInputStream in the JobHistory EventReader. Contributed by Hong Tang
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #112 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/112/)
        . Use DataInputStream rather than FSDataInputStream in the
        JobHistory EventReader. Contributed by Hong Tang

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #112 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/112/ ) . Use DataInputStream rather than FSDataInputStream in the JobHistory EventReader. Contributed by Hong Tang
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3m 11s 1 Hong Tang 07/Oct/09 08:48
        Patch Available Patch Available Resolved Resolved
        6d 22h 54m 1 Chris Douglas 14/Oct/09 07:42
        Resolved Resolved Closed Closed
        314d 14h 35m 1 Tom White 24/Aug/10 22:18

          People

          • Assignee:
            Hong Tang
            Reporter:
            Hong Tang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development