Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-1031

ant tar target doens't seem to compile tests in contrib projects

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ant tar shouldn't be skipping contrib tests.

      1. MAPREDUCE-1031.patch
        3 kB
        Aaron Kimball
      2. MAPREDUCE-1031-branch21.patch
        3 kB
        Aaron Kimball

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #285 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/285/)
        MAPREDUCE-1031. ant tar target doens't seem to compile tests in contrib projects. Contributed by Aaron Kimball.

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #285 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/285/ ) MAPREDUCE-1031 . ant tar target doens't seem to compile tests in contrib projects. Contributed by Aaron Kimball.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Aaron!

        Show
        Tom White added a comment - I've just committed this. Thanks Aaron!
        Hide
        Aaron Kimball added a comment -

        The failing test has been doing so for a few builds now; unrelated to this patch.

        Show
        Aaron Kimball added a comment - The failing test has been doing so for a few builds now; unrelated to this patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12436923/MAPREDUCE-1031.patch
        against trunk revision 916823.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 2252 javac compiler warnings (more than the trunk's current 2219 warnings).

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/490/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/490/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/490/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/490/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12436923/MAPREDUCE-1031.patch against trunk revision 916823. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 2252 javac compiler warnings (more than the trunk's current 2219 warnings). +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/490/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/490/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/490/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/490/console This message is automatically generated.
        Hide
        Aaron Kimball added a comment -

        The build seemed to interrupt midway through. Recycling status to try Hudson again.

        I suspect that there are additional javac warnings because code which previously was not being compiled by Hudson (notably, the data_join and index contrib modules) is now enabled. This patch does not change any Java code, so can't introduce javac warnings in its own right.

        Show
        Aaron Kimball added a comment - The build seemed to interrupt midway through. Recycling status to try Hudson again. I suspect that there are additional javac warnings because code which previously was not being compiled by Hudson (notably, the data_join and index contrib modules) is now enabled. This patch does not change any Java code, so can't introduce javac warnings in its own right.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12436923/MAPREDUCE-1031.patch
        against trunk revision 915223.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 2252 javac compiler warnings (more than the trunk's current 2219 warnings).

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/484/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/484/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/484/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/484/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12436923/MAPREDUCE-1031.patch against trunk revision 915223. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 2252 javac compiler warnings (more than the trunk's current 2219 warnings). +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/484/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/484/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/484/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/484/console This message is automatically generated.
        Hide
        Aaron Kimball added a comment -

        Note: there are no new tests introduced by this patch because it's a buildsystem fix. I manually tested by introducing a syntax error in Sqoop's code and verifying that the package build failed; removing the syntax error allowed the build to proceed successfully.

        Show
        Aaron Kimball added a comment - Note: there are no new tests introduced by this patch because it's a buildsystem fix. I manually tested by introducing a syntax error in Sqoop's code and verifying that the package build failed; removing the syntax error allowed the build to proceed successfully.
        Hide
        Aaron Kimball added a comment -

        Attaching patch to add this to the compilation step. This also exposes the fact that as-is, some contribs do not compile their tests correctly due to missing ivy deps. Fixed those too.

        Show
        Aaron Kimball added a comment - Attaching patch to add this to the compilation step. This also exposes the fact that as-is, some contribs do not compile their tests correctly due to missing ivy deps. Fixed those too.
        Hide
        Arun C Murthy added a comment -

        This lead to MAPREDUCE-1022 ...

        Show
        Arun C Murthy added a comment - This lead to MAPREDUCE-1022 ...

          People

          • Assignee:
            Aaron Kimball
            Reporter:
            Arun C Murthy
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development