[MAILBOX-43] Review if equals or == should be used

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2
• Fix Version/s: 0.2
• Environment: all
• Assignee: Norman Maurer
• Reporter: Felix Knecht
• Created: 22/Mar/11 19:51
• Updated: 22/Mar/11 20:42
• Resolved: 22/Mar/11 20:42

Description

Is it really correct to compare references and not values in following places? Note that this are mostly either String or Long or Integer.
I'm sure there are more. I guess that all these kinds of 'equals' should not compare reference but value.

e.g. JCRHeader.java, compares references instead values.
...
private String fieldName;
private String value;

public boolean equals(Object obj) {
if (this == obj)
return true;
if (obj == null)
return false;
if (getClass() != obj.getClass())
return false;
final JCRHeader other = (JCRHeader) obj;
if (getValue() != other.getValue() || getFieldName() != other.getFieldName())
return false;
return true;
}