[MAILBOX-317] Refactoring StoreManager constructor and hierarchy

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: master
• Component/s: store
• Assignee: Unassigned
• Reporter: Benoit Tellier
• Created: 02/Nov/17 06:11
• Updated: 03/Nov/17 04:23
• Resolved: 03/Nov/17 04:23

Description

StoreMailboxManager has 5 different constructors and it's hierarchy handles a total of ~30 constuctors.

We should rely on a single constructor on StoreMailboxManager, and each class in the hierarchy should only have a single constructor.

To do this:

• We need to remove MailboxManager the responsibility of initialising the event system: it should be passed well initialized to it.
• We should extract annotations. Thus configuration of annotations limit can be handled at THAT level and not impact the entire classhierarchy.

Finally, we can also rely more on InMemoryIntegrationResources to limit direct calls to raw constructors.

I really believe such changes, even painful, brings a :

• way more separated responsibility
• clearer code