Uploaded image for project: 'James Mailbox'
  1. James Mailbox
  2. MAILBOX-191

more effective implementation of StoreMessageResultIterator

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.4, 0.5
    • 0.5
    • store

    Description

      I found problem with current implementation of StoreMessageResultIterator. I discribed it here.
      http://www.mail-archive.com/server-user@james.apache.org/msg14242.html
      Briefly:
      From Thunderbird I got request

      452 UID fetch 16,17:18,20:41,43:45,47,49 (UID RFC822.SIZE BODY.PEEK[])

      which is mapped to calls on MessageMapper.findInMailbox()

      findInMailbox: TYPE: RANGE UID: 16:18, Full
      *findInMailbox: TYPE: FROM UID: 19:-1, Full
      findInMailbox: TYPE: RANGE UID: 20:41, Full
      *findInMailbox: TYPE: FROM UID: 42:-1, Full
      findInMailbox: TYPE: RANGE UID: 43:45, Full
      *findInMailbox: TYPE: FROM UID: 46:-1, Full
      findInMailbox: TYPE: ONE UID: 47:47, Full
      *findInMailbox: TYPE: ONE UID: 48:48, Full
      findInMailbox: TYPE: ONE UID: 49:49, Full

      Those marked calls of method findInMailbox are completely unnecessary and should be avoided.

      Attachments

        1. StoreMessageResultIterator.patch
          3 kB
          Peter Kvokacka
        2. StoreMessageResultIterator.java
          3 kB
          Peter Kvokacka

        Activity

          People

            eric@apache.org Eric Charles
            kvokacka Peter Kvokacka
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: