[MAHOUT-642] Wrong parameter order in LoglikelihoodSimilarity and DistributedLoglikelihoodVectorSimilarity

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.5
• Fix Version/s: 0.5
• Assignee: Sebastian Schelter
• Reporter: Sebastian Schelter
• Created: 30/Mar/11 14:14
• Updated: 21/May/11 03:18
• Resolved: 30/Mar/11 19:37

Description

org.apache.mahout.math.stats.LogLikelihood.logLikelihoodRatio expects the following counts:

• A and B together (k_11)
• B without A (k_12)
• A without B (k_21)
• Neither A nor B (k_22)

It seems to me that in org.apache.mahout.cf.taste.impl.similarity.LogLikelihoodSimilarity and org.apache.mahout.math.hadoop.similarity.vector.DistributedLoglikelihoodVectorSimilarity the counts of k_12 and k_21 are given in the wrong order (B without A should come before A without B)

Can someone confirm that?