Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4
    • Component/s: None
    • Labels:
      None

      Description

      Upgrade Lucene version used to the latest release.

      1. MAHOUT-388.patch
        9 kB
        Drew Farris
      2. MAHOUT-388.patch
        9 kB
        Drew Farris

        Activity

        Hide
        Drew Farris added a comment - - edited

        This seems pretty straightforward considering Collections.<String>emptySet() will handle the minor API changes.

        One issue I ran into was that StandardAnalyzer no longer has a no-arg constructor – this causes (at a minimum) the DictionaryVectorizerTest to break. We either wrap StandardAnalyzer in something that does provide a no-arg constructor or consider revising the analyzer instantiation pattern. I think the latter is worth spending some time on at some point, but I'm inclined to punt for now, any other thoughts?

        Show
        Drew Farris added a comment - - edited This seems pretty straightforward considering Collections.<String>emptySet() will handle the minor API changes. One issue I ran into was that StandardAnalyzer no longer has a no-arg constructor – this causes (at a minimum) the DictionaryVectorizerTest to break. We either wrap StandardAnalyzer in something that does provide a no-arg constructor or consider revising the analyzer instantiation pattern. I think the latter is worth spending some time on at some point, but I'm inclined to punt for now, any other thoughts?
        Hide
        Drew Farris added a comment -

        Updates to Lucene 3.0.1, created DefaultAnalyzer in mahout-util which extends StandardAnalyer and provides a no-arg constructor required by the document vectorization code.

        Despite deprecation, continued to use Version.CURRENT_VERSION in the constructor arg for StandardAnalyzer as this is consistent with the rest of the mahout code.

        Show
        Drew Farris added a comment - Updates to Lucene 3.0.1, created DefaultAnalyzer in mahout-util which extends StandardAnalyer and provides a no-arg constructor required by the document vectorization code. Despite deprecation, continued to use Version.CURRENT_VERSION in the constructor arg for StandardAnalyzer as this is consistent with the rest of the mahout code.
        Hide
        Drew Farris added a comment -

        Any objections to this? If not I'll plan on committing in a couple days.

        Show
        Drew Farris added a comment - Any objections to this? If not I'll plan on committing in a couple days.
        Hide
        Drew Farris added a comment -

        updated patch to apply cleanly against r942962

        Show
        Drew Farris added a comment - updated patch to apply cleanly against r942962
        Hide
        Drew Farris added a comment -

        Committed revision 942986

        Show
        Drew Farris added a comment - Committed revision 942986

          People

          • Assignee:
            Drew Farris
            Reporter:
            Grant Ingersoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development