[MAHOUT-269] Vector.maxValue() returns Double.MIN_VALUE for vectors with all negative entries.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.1, 0.2
• Fix Version/s: 0.3
• Component/s: classic
• Assignee: Jake Mannix
• Reporter: Jake Mannix
• Created: 27/Jan/10 16:31
• Updated: 31/Jan/24 22:16
• Resolved: 28/Jan/10 06:13

Description

  @Override
  public double maxValue() {
    double result = Double.MIN_VALUE;
    for (int i = 0; i < size(); i++) {
      result = Math.max(result, getQuick(i));
    }
    return result;
  }

Should be:

  @Override
  public double maxValue() {
    double result = 0;
    for (int i = 0; i < size(); i++) {
      result = Math.max(result, Math.abs(getQuick(i)));
    }
    return result;
  }

Right? MaxValue should be returning the max of the absolute value, not the real max, right? And the maxValue of the zero vector is 0, not MIN_VALUE, yes?