Uploaded image for project: 'Mahout'
  1. Mahout
  2. MAHOUT-1702

Mahout DSL for Flink: implement element-wise operators

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0
    • Component/s: Math
    • Labels:

      Description

      as a part of MAHOUT-1570 implement the following operators on Flink:

      • AewB
      • AewScalar

        Issue Links

          Activity

          Show
          agrigorev Alexey Grigorev added a comment - Implemented at https://github.com/alexeygrigorev/mahout/commit/434901552effa5594ecdda1101183e2340d0d068
          Hide
          agrigorev Alexey Grigorev added a comment -

          Dmitriy Lyubimov, is AewScalar fully deprecated now? I switched to OpAewUnaryFunc already - should I remove the old code?

          Show
          agrigorev Alexey Grigorev added a comment - Dmitriy Lyubimov , is AewScalar fully deprecated now? I switched to OpAewUnaryFunc already - should I remove the old code?
          Hide
          dlyubimov Dmitriy Lyubimov added a comment -

          IIRC, the upper-level optimizer rewriter will not produce AewScalar ops anymore. (there's 10% chance i might be wrong). The best way to know is to make sure the tests pass (backends are assumed to pass all tests by extending `***BaseSuite`s in the o.a.m.math.drm

          Show
          dlyubimov Dmitriy Lyubimov added a comment - IIRC, the upper-level optimizer rewriter will not produce AewScalar ops anymore. (there's 10% chance i might be wrong). The best way to know is to make sure the tests pass (backends are assumed to pass all tests by extending `***BaseSuite`s in the o.a.m.math.drm
          Hide
          agrigorev Alexey Grigorev added a comment -

          Thanks! Didn't know about this BaseSuites - so far I had only my own tests. Will add it!

          Show
          agrigorev Alexey Grigorev added a comment - Thanks! Didn't know about this BaseSuites - so far I had only my own tests. Will add it!
          Hide
          Andrew_Palumbo Andrew Palumbo added a comment - - edited

          This seems to be working fine with the base suites. I think we can resolve it.

          Show
          Andrew_Palumbo Andrew Palumbo added a comment - - edited This seems to be working fine with the base suites. I think we can resolve it.
          Hide
          dlyubimov Dmitriy Lyubimov added a comment -

          bulk-closing resolved issues

          Show
          dlyubimov Dmitriy Lyubimov added a comment - bulk-closing resolved issues
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Mahout-Quality #3324 (See https://builds.apache.org/job/Mahout-Quality/3324/)
          MAHOUT-1702: Flink: AewScalar and AewB (alexey.s.grigoriev: rev 92f48afbb6da34e58ce738eef44f2dec80a60bf1)

          • flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAewB.scala
          • flink/src/test/scala/org/apache/mahout/flinkbindings/blas/LATestSuit.scala
          • flink/src/main/scala/org/apache/mahout/flinkbindings/FlinkEngine.scala
          • flink/src/test/scala/org/apache/mahout/flinkbindings/UseCasesSuite.scala
          • flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAewScalar.scala
          • flink/src/test/scala/org/apache/mahout/flinkbindings/RLikeOpsSuite.scala
            MAHOUT-1702: Flink: AewScalar replaced with OpAewUnaryFunc (alexey.s.grigoriev: rev f66477fc53581796035e1dfef06d57e12719f1c5)
          • flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAewScalar.scala
            MAHOUT-1702: Flink: unary functions (alexey.s.grigoriev: rev 2a4e9690c82fa341741f52fa7ccb64cab8ea66df)
          • flink/src/main/scala/org/apache/mahout/flinkbindings/FlinkEngine.scala
          • flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAewScalar.scala
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Mahout-Quality #3324 (See https://builds.apache.org/job/Mahout-Quality/3324/ ) MAHOUT-1702 : Flink: AewScalar and AewB (alexey.s.grigoriev: rev 92f48afbb6da34e58ce738eef44f2dec80a60bf1) flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAewB.scala flink/src/test/scala/org/apache/mahout/flinkbindings/blas/LATestSuit.scala flink/src/main/scala/org/apache/mahout/flinkbindings/FlinkEngine.scala flink/src/test/scala/org/apache/mahout/flinkbindings/UseCasesSuite.scala flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAewScalar.scala flink/src/test/scala/org/apache/mahout/flinkbindings/RLikeOpsSuite.scala MAHOUT-1702 : Flink: AewScalar replaced with OpAewUnaryFunc (alexey.s.grigoriev: rev f66477fc53581796035e1dfef06d57e12719f1c5) flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAewScalar.scala MAHOUT-1702 : Flink: unary functions (alexey.s.grigoriev: rev 2a4e9690c82fa341741f52fa7ccb64cab8ea66df) flink/src/main/scala/org/apache/mahout/flinkbindings/FlinkEngine.scala flink/src/main/scala/org/apache/mahout/flinkbindings/blas/FlinkOpAewScalar.scala

            People

            • Assignee:
              smarthi Suneel Marthi
              Reporter:
              agrigorev Alexey Grigorev
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile