[MADLIB-1417] DL: Support schema qualified output tables for fit and fit_multiple

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: v1.17
• Component/s: Deep Learning
• Assignee: Orhan Kislal
• Reporter: Nikhil Kak
• Created: 05/Mar/20 00:39
• Updated: 12/Mar/20 20:41
• Resolved: 12/Mar/20 20:41

Description

dev-check fails if the output table is schema qualified.

I modified the madlib_keras_transfer_learning dev-check test by schema qualifying the output table argument in fit multiple

SELECT madlib_keras_fit_multiple_model(
  'iris_data_packed',
  'public.iris_multiple_model',
  'mst_table',
  3,
  FALSE, NULL, 1
); 

and

SELECT madlib_keras_fit_multiple_model(
  'iris_data_packed',
  'public.iris_multiple_model',
  'mst_table',
  3,
  FALSE,
  NULL, 1,
  TRUE -- warm_start
); 

 

Both of these cases fail because of different reasons.

It is also likely that madlib_keras_fit is also broken when a schema qualified output table is passed in. We should add tests for all the dl functions that create an output table and fix all the failures.