[MADLIB-1184] k-NN install check fails on non-madlib schema name

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: v1.13
• Component/s: k-NN
• Assignee: Unassigned
• Reporter: Nandish Jayaram
• Created: 30/Nov/17 22:23
• Updated: 01/Dec/17 23:11
• Resolved: 01/Dec/17 18:05

Description

The install check fails when MADlib is installed on a schema named
anything other than `madlib`. The issue seems to be because the fn_dist
param expects a distance function name prefixed with `<madlib_schema>.`

With MADlib installed on schema `mad`, the following error happens:

psql:/tmp/madlib.OIue8c/knn/test/knn.sql_in.tmp:155: ERROR:  spiexceptions.InvalidSchemaName: schema "madlib" does not exist
LINE 3:                 oid='madlib.squared_dist_norm2(DOUBLE PRECIS...
                            ^
QUERY:  select prorettype != 'DOUBLE PRECISION'::regtype
                OR proisagg = TRUE AS OUTPUT from pg_proc where
                oid='madlib.squared_dist_norm2(DOUBLE PRECISION[], DOUBLE PRECISION[])'::regprocedure;

CONTEXT:  Traceback (most recent call last):
  PL/Python function "knn", line 35, in <module>
    fn_dist
  PL/Python function "knn", line 147, in knn
  PL/Python function "knn", line 100, in knn_validate_src

Issue Links

• links to: GitHub Pull Request #207