Uploaded image for project: 'Lucy'
  1. Lucy
  2. LUCY-72

use short names wherever CHAZ_USE_SHORT_NAMES is in effect

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Charmonizer
    • Labels:
      None

      Description

      Function names in .c files always use "short names"
      whenever the "LUCY_USE_SHORT_NAMES" macro is in effect – e.g. we use
      "Sort_mergesort" rather than "lucy_Sort_mergesort".

      Within Charmonizer, we should be consistent about using short names
      everywhere the "CHAZ_USE_SHORT_NAMES" macro is in effect, but currently
      there are lots of places that we don't – e.g. we use "chaz_Test_plan"
      rather than "Test_plan" within charmonizer/src/Charmonizer/Test.charm:

      void
      -chaz_Test_plan(TestBatch *batch)
      +Test_plan(TestBatch *batch)

      { printf("1..%u\n", batch->num_tests); }

        Attachments

        1. charmonize_c_short_names.diff
          2 kB
          Marvin Humphrey
        2. chaz_prefix-cleanup.patch
          78 kB
          Marvin Humphrey
        3. chaz_prefix-cleanup.patch
          80 kB
          Marvin Humphrey
        4. chaz_prefix-cleanup.patch
          66 kB
          Peter Karman

          Activity

            People

            • Assignee:
              marvin Marvin Humphrey
              Reporter:
              karpet Peter Karman
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: