[LUCY-294] Nul-terminate C strings in test code

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: Test
• Assignee: Marvin Humphrey
• Reporter: Marvin Humphrey
• Created: 14/Mar/16 21:44
• Updated: 18/Feb/17 19:31
• Resolved: 18/Feb/17 19:31

Description

The behavior of String's `Get_Ptr8` method has changed: it now consistently returns a memory buffer which is not nul-terminated.

Lucy uses `Get_Ptr8` in numerous places. All of the runtime usages are OK, but there are a number of test cases that improperly assume that it returns a nul-terminated C string.

The solution is to use `To_Utf8` instead, which returns a newly allocated nul-terminated buffer.