Lucy
  1. Lucy
  2. LUCY-176

More INCREF/DECREF symbol collisions under Windows

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.2.0 (incubating), 0.2.1 (incubating)
    • Component/s: Core
    • Labels:
      None

      Description

      In LUCY-167, we fixed the INCREF/DECREF symbol collisions in FSDirHandle.c,
      but there were others lurking elsewhere that were missed because none of our
      test systems had the necessary pattern of header file inclusion to trigger the
      bug. As before, we need to swap out INCREF/DECREF for
      CFISH_INCREF/CFISH_DECREF to avoid colliding with the symbols exported by
      windows.h.

      1. LUCY-176.patch
        2 kB
        Marvin Humphrey

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        10d 20h 16m 1 Marvin Humphrey 02/Sep/11 18:42
        Marvin Humphrey made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Marvin Humphrey added a comment -

        The patch needed a slight modification under the 0.2 branch, since
        on trunk we have changed LUCY_INCREF to CFISH_INCREF.

        Show
        Marvin Humphrey added a comment - The patch needed a slight modification under the 0.2 branch, since on trunk we have changed LUCY_INCREF to CFISH_INCREF.
        Marvin Humphrey made changes -
        Field Original Value New Value
        Attachment LUCY-176.patch [ 12491268 ]
        Marvin Humphrey created issue -

          People

          • Assignee:
            Marvin Humphrey
            Reporter:
            Marvin Humphrey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development