Uploaded image for project: 'Lucene.Net'
  1. Lucene.Net
  2. LUCENENET-626

API: Review to ensure IDisposable is being used correctly and disposable pattern implemented correctly

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Description

    There have been several issues found recently with the disposable pattern not being implemented correctly. I have also been made aware that there is at least one class (Lucene.Net.Store.Lock, if I recall correctly) that is designed to be re-opened after it is closed.

    We need a review to ensure all classes that implement disposable are doing it correctly and have correctly implemented the dispose pattern both for sealed and unsealed types. We also need to have a close look at whether any classes should be reverted back to using Close() instead of Dispose() on account that the class instance was designed to be used again after the Dispose() call.

      Attachments

      Issue Links

        Activity

          People

          • Assignee:
            Unassigned
            Reporter:
            nightowl888 Shad Storhaug

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 50h
              50h
              Remaining:
              Remaining Estimate - 50h
              50h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Issue deployment