[LUCENENET-467] .NETify the public API where appropriate

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Lucene.Net 2.9.2, Lucene.Net 2.9.4, Lucene.Net 2.9.4g, Lucene.Net 3.0.3
• Fix Version/s: Lucene.Net 3.6
• Component/s: Lucene.Net Contrib, Lucene.Net Core
• Labels: refactoring

Environment

all

• Assignee: Unassigned
• Reporter: Christopher Calvin Currens
• Created: 24/Jan/12 06:06
• Updated: 09/Dec/21 17:58
• Resolved: 09/Dec/21 17:58

Description

Although we haven't abandoned the line-by-line port of Java lucene, there are many idioms in Java that make little to no sense in a .NET assembly. The API can change to allow for a conventional .NET experience, while still maintaining the ability and ease during the porting process of Java logic.

• Change Getxxx() and Setxxx() methods to .NET Properties
• Implement the dispose pattern properly. Try, at all costs, to only use finalizers when necessary. They are expensive, and most of the classes used already have finalizers that will be called.
• Convert Java Iterator-style classes (see TermEnum, TermDocs and others) to implement IEnumerable<T>
• When catching exceptions, do not use throw; instead of throw ex; to maintain the stack trace

Sub-Tasks

• Implement the Dispose pattern properly in classes with Close: Resolved
• Change Getxxx() and Setxxx() methods to .NET Properties: Resolved
• Convert Java Iterator classes to implement IEnumerable<T>: Closed