Uploaded image for project: 'Lucene.Net'
  1. Lucene.Net
  2. LUCENENET-426

Mark BaseFragmentsBuilder methods as virtual

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Lucene.Net 2.9.2, Lucene.Net 2.9.4, Lucene.Net 2.9.4g, Lucene.Net 3.0.3
    • Component/s: Lucene.Net Contrib
    • Labels:
      None

      Description

      Without marking methods in BaseFragmentsBuilder as virtual, it is meaningless to have FragmentsBuilder deriving from a class named "Base", since most of its functionality cannot be overridden. Attached is a patch for marking the important methods virtual.

        Attachments

        1. fvh.patch
          2 kB
          Itamar Syn-Hershko

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              itamar Itamar Syn-Hershko
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: