[LUCENE-9885] error param use in RadixSelector

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Won't Do
• Affects Version/s: 8.8
• Component/s: core/other
• Labels: patch
• Lucene Fields: Patch Available
• Review Patch?: Yes
• Assignee: Unassigned
• Reporter: liupanfeng
• Created: 27/Mar/21 12:07
• Updated: 28/Aug/22 16:19
• Resolved: 27/Mar/21 12:31

Description

there is error param used in org.apache.lucene.util.RadixSelector#select(int, int, int, int, int).

what we expected in this method is:

if the range becomes narrow or when the maximum level of recursion has been exceeded, then we get a fall-back selector(IntroSelector).

so we should use the param l compare with level_threshold. NOT d.

effect:  This does not affect the correctness of the program. but affect performance in some case. RadixSelector and IntroSelector are all in linear time. but this bug made bigger constatns.

 

other evidence: 

1. in comment. said maximum level of recursion has been exceeded. not the length of value.

2. if d is right. the param f will never used in all method. It could be delete.

 

Thanks for you read. I'm new of lucene, so reply me if I am wrong. or fix it.